Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html

Issue 2932593002: Attempt 2: Update PaintTiming Web Perf APIs for FP & FCP to report swap time (Closed)
Patch Set: rebase to head Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html b/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html
index 8bc773295ed82183c22ca54e3b2cdc0e9358e0d2..9600ebff552fc75452e91adce08159643d0d1215 100644
--- a/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html
+++ b/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-svg.html
@@ -1,43 +1,28 @@
<!DOCTYPE html>
<head>
-<title>Performance Paint Timing Test</title>
+<title>Performance Paint Timing Test: FCP due to SVG</title>
</head>
<body>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
+ <div id="svg"></div>
+
<script>
async_test(function (t) {
- var observer = new PerformanceObserver(
- t.step_func(function (entryList) {
- var entries = entryList.getEntries();
- assert_equals(entries.length, 2,
- "There should be two paint timing instances.");
- assert_equals(entries[0].entryType, "paint",
- "Expected entryType to be: paint.");
- assert_equals(entries[0].duration, 0,
- "Expected duration to be: 0.");
-
- assert_equals(entries[1].entryType, "paint",
- "Expected entryType to be: paint.");
- assert_equals(entries[1].duration, 0,
- "Expected duration to be: 0.");
- observer.disconnect();
- t.done();
- })
- );
- observer.observe({entryTypes: ["paint"]});
-
+ const img = document.createElement("IMG");
+ img.src = "resources/circle.svg";
+ img.onload = function() {
+ testRunner.capturePixelsAsyncThen(t.step_func_done(function() {
+ const bufferedEntries = performance.getEntriesByType('paint');
+ assert_equals(bufferedEntries.length, 2, "There should be two paint timing instances.");
+ assert_equals(bufferedEntries[0].entryType, "paint");
+ assert_equals(bufferedEntries[0].name, "first-paint");
+ assert_equals(bufferedEntries[1].entryType, "paint");
+ assert_equals(bufferedEntries[1].name, "first-contentful-paint");
+ }));
+ };
+ document.getElementById('svg').appendChild(img);
}, "First contentful paint fires due to svg.");
</script>
-
- <script>
- window.onload = function() {
- var img = document.createElement("IMG");
- img.src = "resources/circle.svg";
- document.getElementById('svg').appendChild(img);
- }
- </script>
-
- <div id="svg"></div>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698