third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html - Issue 2932593002: Attempt 2: Update PaintTiming Web Perf APIs for FP & FCP to report swap time

Unified Diff: third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html

Issue 2932593002: Attempt 2: Update PaintTiming Web Perf APIs for FP & FCP to report swap time (Closed)

Patch Set: rebase to head Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-canvas.html ('k') | third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-paint.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html b/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html

index 531214284c1b21fa418e71d8f1ca1279a1db631d..1ef323f7ca696bea4f7109a0c2fc23f1d44ab5ef 100644

--- a/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html

+++ b/third_party/WebKit/LayoutTests/http/tests/performance-timing/paint-timing/first-contentful-image.html

@@ -1,43 +1,28 @@

<!DOCTYPE html>

<head>

-<title>Performance Paint Timing Test</title>

+<title>Performance Paint Timing Test: FCP due to image</title>

</head>

<body>

- <script>

- async_test(function (t) {

- var observer = new PerformanceObserver(

- t.step_func(function (entryList) {

- var entries = entryList.getEntries();

- assert_equals(entries.length, 2,

- "There should be two paint timing instances.");

- assert_equals(entries[0].entryType, "paint",

- "Expected entryType to be: paint.");

- assert_equals(entries[0].duration, 0,

- "Expected duration to be: 0.");

- assert_equals(entries[1].entryType, "paint",

- "Expected entryType to be: paint.");

- assert_equals(entries[1].duration, 0,

- "Expected duration to be: 0.");

- observer.disconnect();

- t.done();

- })

- );

- observer.observe({entryTypes: ["paint"]});

- }, "First contentful paint fires due to image render.");

- </script>

+ <div id="image"></div>

- window.onload = function() {

- var img = document.createElement("IMG");

+ async_test(function (t) {

+ const img = document.createElement("IMG");

img.src = "resources/circles.png";

+ img.onload = function() {

+ testRunner.capturePixelsAsyncThen(t.step_func_done(function() {

+ const bufferedEntries = performance.getEntriesByType('paint');

+ assert_equals(bufferedEntries.length, 2, "There should be two paint timing instances.");

+ assert_equals(bufferedEntries[0].entryType, "paint");

+ assert_equals(bufferedEntries[0].name, "first-paint");

+ assert_equals(bufferedEntries[1].entryType, "paint");

+ assert_equals(bufferedEntries[1].name, "first-contentful-paint");

+ }));

+ };

document.getElementById('image').appendChild(img);

- }

+ }, "First contentful paint fires due to image render.");

</script>

- <div id="image"></div>

</body>

</html>