Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2932553004: Add tests for recently added mixins and improve plugin tests (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for recently added mixins and improve plugin tests R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/624f4d8b3d5de5248fce587e2162d59a74de2e98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+768 lines, -57 lines) Patch
A pkg/analyzer_plugin/test/plugin/assist_mixin_test.dart View 1 chunk +96 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/plugin/completion_mixin_test.dart View 1 chunk +106 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/plugin/fix_mixin_test.dart View 1 chunk +104 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/plugin/mocks.dart View 1 chunk +162 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/plugin/navigation_mixin_test.dart View 1 chunk +96 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/plugin/plugin_test.dart View 6 chunks +196 lines, -57 lines 0 comments Download
M pkg/analyzer_plugin/test/plugin/test_all.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-08 23:37:04 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-09 00:48:11 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-09 14:27:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
624f4d8b3d5de5248fce587e2162d59a74de2e98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698