Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

Issue 2932543002: DevTools: reveal and highlight dom nodes when searching in elements panel. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
index d3a4668ffa3b2d9200fcc67624bcce1cfd7d95d8..7f2675abe6b91bf492f15707203337e31cf9b9cb 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
@@ -861,19 +861,11 @@ SDK.DOMNode = class {
this._domModel.overlayModel().highlightDOMNodeForTwoSeconds(this.id);
}
- /**
- * @param {string=} objectGroup
- * @param {function(?SDK.RemoteObject)=} callback
- */
- resolveToObject(objectGroup, callback) {
- this.resolveToObjectPromise(objectGroup).then(object => callback && callback(object));
- }
-
/**
* @param {string=} objectGroup
* @return {!Promise<?SDK.RemoteObject>}
*/
- async resolveToObjectPromise(objectGroup) {
+ async resolveToObject(objectGroup) {
var object = await this._agent.resolveNode(this.id, objectGroup);
return object && this._domModel._runtimeModel.createRemoteObject(object);
}
@@ -912,6 +904,23 @@ SDK.DOMNode = class {
node = null;
return node;
}
+
+ async scrollIntoView() {
caseq 2017/06/07 21:22:29 scrollIntoViewAndHighlight()?
+ var node = this.enclosingElementOrSelf();
caseq 2017/06/07 21:22:29 var element =
+ var object = await node.resolveToObject('');
+ if (object)
+ object.callFunction(scrollIntoView);
+ object.release();
+ node.highlightForTwoSeconds();
+
+ /**
+ * @suppressReceiverCheck
+ * @this {!Element}
+ */
+ function scrollIntoView() {
+ this.scrollIntoViewIfNeeded(true);
+ }
+ }
};
/**

Powered by Google App Engine
This is Rietveld 408576698