Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js

Issue 2932543002: DevTools: reveal and highlight dom nodes when searching in elements panel. (Closed)
Patch Set: rebaseline Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2014 Google Inc. All rights reserved. 3 * Copyright (C) 2014 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 delete this._lastRequestedNode; 64 delete this._lastRequestedNode;
65 } 65 }
66 66
67 if (!this._node) { 67 if (!this._node) {
68 this.element.removeChildren(); 68 this.element.removeChildren();
69 this.sections = []; 69 this.sections = [];
70 return Promise.resolve(); 70 return Promise.resolve();
71 } 71 }
72 72
73 this._lastRequestedNode = this._node; 73 this._lastRequestedNode = this._node;
74 return this._node.resolveToObjectPromise(Elements.PropertiesWidget._objectGr oupName).then(nodeResolved.bind(this)); 74 return this._node.resolveToObject(Elements.PropertiesWidget._objectGroupName ).then(nodeResolved.bind(this));
75 75
76 /** 76 /**
77 * @param {?SDK.RemoteObject} object 77 * @param {?SDK.RemoteObject} object
78 * @this {Elements.PropertiesWidget} 78 * @this {Elements.PropertiesWidget}
79 */ 79 */
80 function nodeResolved(object) { 80 function nodeResolved(object) {
81 if (!object) 81 if (!object)
82 return; 82 return;
83 83
84 /** 84 /**
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 return; 165 return;
166 var data = event.data; 166 var data = event.data;
167 var node = /** @type {!SDK.DOMNode} */ (data instanceof SDK.DOMNode ? data : data.node); 167 var node = /** @type {!SDK.DOMNode} */ (data instanceof SDK.DOMNode ? data : data.node);
168 if (this._node !== node) 168 if (this._node !== node)
169 return; 169 return;
170 this.update(); 170 this.update();
171 } 171 }
172 }; 172 };
173 173
174 Elements.PropertiesWidget._objectGroupName = 'properties-sidebar-pane'; 174 Elements.PropertiesWidget._objectGroupName = 'properties-sidebar-pane';
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698