Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 293253002: Reenable UpdateDynamicPKPMaxAge0 test. (Closed)

Created:
6 years, 7 months ago by palmer
Modified:
6 years, 5 months ago
Reviewers:
wtc, agl, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Reenable UpdateDynamicPKPMaxAge0 test. BUG=375538 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281863

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M net/http/http_security_headers_unittest.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
palmer
This is really odd. It's consistently failing on some, but not all, Windows configurations. And ...
6 years, 7 months ago (2014-05-27 22:59:42 UTC) #1
wtc
Patch set 1 LGTM. However, I don't know why this test fails on some but ...
6 years, 7 months ago (2014-05-28 01:06:14 UTC) #2
Ryan Sleevi
I'm nervous re-enabling it, since it blocked CQ, without a strong amount of babysitting or ...
6 years, 7 months ago (2014-05-28 01:42:58 UTC) #3
palmer
> Things that come to mind are "timing" or "persistence". > > Beyond that, "memory ...
6 years, 6 months ago (2014-05-28 21:33:07 UTC) #4
Ryan Sleevi
The infrastructure team can help you get access to a bot for testing. On Wed, ...
6 years, 6 months ago (2014-05-28 21:35:05 UTC) #5
palmer
The CQ bit was checked by palmer@chromium.org
6 years, 5 months ago (2014-07-08 17:29:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/293253002/20001
6 years, 5 months ago (2014-07-08 17:32:01 UTC) #7
commit-bot: I haz the power
Change committed as 281863
6 years, 5 months ago (2014-07-08 23:02:29 UTC) #8
jam
6 years, 5 months ago (2014-07-25 06:33:29 UTC) #9
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/412353006/ by jam@chromium.org.

The reason for reverting is: this is still flaking. more info in bug.

Powered by Google App Engine
This is Rietveld 408576698