Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: chrome/browser/ui/views/harmony/harmony_layout_provider.cc

Issue 2932523003: Fix Harmony popover buttons being flush with their content. (Closed)
Patch Set: too much padding for bubbles Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/harmony/harmony_layout_provider.cc
diff --git a/chrome/browser/ui/views/harmony/harmony_layout_provider.cc b/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
index fd1c37ad613a1a9663fb52d55b1a9c9c81b6b381..e6893f89c4234b5c3dc69d3a37fcf18cb2e93196 100644
--- a/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
+++ b/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
@@ -17,6 +17,7 @@ gfx::Insets HarmonyLayoutProvider::GetInsetsMetric(int metric) const {
int HarmonyLayoutProvider::GetDistanceMetric(int metric) const {
DCHECK_GE(metric, views::VIEWS_INSETS_MAX);
switch (metric) {
+ case views::DISTANCE_BUBBLE_BUTTON_TOP_MARGIN:
case views::DISTANCE_BUBBLE_CONTENTS_HORIZONTAL_MARGIN:
case views::DISTANCE_BUBBLE_CONTENTS_VERTICAL_MARGIN:
case views::DISTANCE_DIALOG_CONTENTS_HORIZONTAL_MARGIN:
@@ -42,8 +43,6 @@ int HarmonyLayoutProvider::GetDistanceMetric(int metric) const {
return kHarmonyLayoutUnit / 2;
case views::DISTANCE_DIALOG_BUTTON_BOTTOM_MARGIN:
return kHarmonyLayoutUnit;
- case DISTANCE_DIALOG_BUTTON_TOP:
- return kHarmonyLayoutUnit;
case views::DISTANCE_DIALOG_BUTTON_MINIMUM_WIDTH:
case DISTANCE_BUTTON_MINIMUM_WIDTH:
// Minimum label size plus padding.

Powered by Google App Engine
This is Rietveld 408576698