Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: net/http/http_stream_factory_impl_job.h

Issue 2932513004: Throttle HttpStreamFactoryImpl::Job to HTTP/2-supported servers (Closed)
Patch Set: self Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job.cc » ('j') | net/http/http_stream_factory_impl_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job.h
diff --git a/net/http/http_stream_factory_impl_job.h b/net/http/http_stream_factory_impl_job.h
index 91c3def5cb8726f383f8909865f8b192d71b556f..e0f0646b9c315d9f0b0024ed275ad766b438441e 100644
--- a/net/http/http_stream_factory_impl_job.h
+++ b/net/http/http_stream_factory_impl_job.h
@@ -269,6 +269,7 @@ class HttpStreamFactoryImpl::Job {
STATE_WAIT,
STATE_WAIT_COMPLETE,
+ STATE_BEFORE_INIT_CONNECTION,
Ryan Hamilton 2017/06/12 13:30:49 nit: Instead of "before init connection" there the
xunjieli 2017/06/13 15:23:10 Done.
STATE_INIT_CONNECTION,
STATE_INIT_CONNECTION_COMPLETE,
STATE_WAITING_USER_ACTION,
@@ -313,6 +314,8 @@ class HttpStreamFactoryImpl::Job {
int DoStart();
int DoWait();
int DoWaitComplete(int result);
+ int DoBeforeInitConnection();
+ int DoBeforeInitConnectionComplete(int result);
int DoInitConnection();
int DoInitConnectionComplete(int result);
int DoWaitingUserAction(int result);
@@ -321,6 +324,7 @@ class HttpStreamFactoryImpl::Job {
int DoRestartTunnelAuth();
int DoRestartTunnelAuthComplete(int result);
+ void ResumeInitConnection();
// Creates a SpdyHttpStream or a BidirectionalStreamImpl from the given values
// and sets to |stream_| or |bidirectional_stream_impl_| respectively. Does
// nothing if |stream_factory_| is for WebSockets.
@@ -480,6 +484,9 @@ class HttpStreamFactoryImpl::Job {
// Type of stream that is requested.
HttpStreamRequest::StreamType stream_type_;
+ // Whether the Job should continue to DoInitConnection().
Bence 2017/06/09 19:17:38 Isn't it rather whether the Job has already contin
xunjieli 2017/06/13 15:23:10 Done.
+ bool resumed_init_connection_;
Bence 2017/06/09 19:17:38 Optional: init_connection_already_resumed_.
xunjieli 2017/06/13 15:23:10 Done.
+
base::WeakPtrFactory<Job> ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(Job);
« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job.cc » ('j') | net/http/http_stream_factory_impl_job.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698