update errorCodeValues

update errorCodeValues

Add the new fasta Scanner error codes to the errorCodeValues list
and add a test to ensure that any new error codes will also be added.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/d675a7c37568c9bcfa1c85b6d13856179581453b

[danrubel, 2017-06-07 18:02:23]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-06-07 18:09:52]

https://codereview.chromium.org/2932483002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/options_test.dart (right):

https://codereview.chromium.org/2932483002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/options_test.dart:148: class
ErrorFilterOptionValidatorTest {
Hm... The name of the test is strange.
Why is it a filter? Which option?
Probably ErrorCodeValuesTest is better.

https://codereview.chromium.org/2932483002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/options_test.dart:175:
declaredNames.remove('INCLUDED_FILE_PARSE_ERROR');
I don't like using string names.
Could we use AnalysisOptionsErrorCode.INCLUDED_FILE_PARSE_ERROR.name instead?
So, renames and removes will update / show.

[danrubel, 2017-06-07 18:43:06]

https://codereview.chromium.org/2932483002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/options_test.dart (right):

https://codereview.chromium.org/2932483002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/options_test.dart:148: class
ErrorFilterOptionValidatorTest {
On 2017/06/07 18:09:51, scheglov wrote:
> Hm... The name of the test is strange.
> Why is it a filter? Which option?
> Probably ErrorCodeValuesTest is better.

Good point. Renamed.

https://codereview.chromium.org/2932483002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/options_test.dart:175:
declaredNames.remove('INCLUDED_FILE_PARSE_ERROR');
On 2017/06/07 18:09:51, scheglov wrote:
> I don't like using string names.
> Could we use AnalysisOptionsErrorCode.INCLUDED_FILE_PARSE_ERROR.name instead?
> So, renames and removes will update / show.

Great suggestion. Refactored.

[danrubel, 2017-06-07 18:44:15]

CL updated. PTAL

[scheglov, 2017-06-07 18:45:15]

LGTM

[danrubel, 2017-06-08 16:36:01]

Description was changed from

==========
update errorCodeValues

Add the new fasta Scanner error codes to the errorCodeValues list
and add a test to ensure that any new error codes will also be added.
==========

to

==========
update errorCodeValues

Add the new fasta Scanner error codes to the errorCodeValues list
and add a test to ensure that any new error codes will also be added.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d675a7c37568c9bcfa1c85b6d13856179581453b
==========

[danrubel, 2017-06-08 16:36:07]

Committed patchset #2 (id:20001) manually as
d675a7c37568c9bcfa1c85b6d13856179581453b (presubmit successful).