Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2932453002: PlzNavigate: Release StreamHandle. (Closed)
Patch Set: Add test. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index c595af5eaa1ce9775cc1bcd2c25e9b0be49b5cea..128fc53cca768ebda620e411697b0432d06f9f8f 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -5134,6 +5134,18 @@ void RenderFrameImpl::OnCommitNavigation(
stream_override->redirect_responses = request_params.redirect_response;
stream_override->redirect_infos = request_params.redirect_infos;
+ // Used to notify the browser that it can release its |stream_handle_| when
+ // the |stream_override| object isn't used anymore.
+ // TODO(clamy): Remove this when we switch to Mojo streams.
+ stream_override->on_delete = base::BindOnce(
+ [](base::WeakPtr<RenderFrameImpl> weak_self, const GURL& url) {
+ if (RenderFrameImpl* self = weak_self.get()) {
+ self->Send(
+ new FrameHostMsg_StreamHandleConsumed(self->routing_id_, url));
+ }
+ },
+ weak_factory_.GetWeakPtr());
+
if (commit_data.url_loader_factory.is_valid()) {
// Chrome doesn't use interface versioning.
url_loader_factory_.Bind(mojom::URLLoaderFactoryPtrInfo(

Powered by Google App Engine
This is Rietveld 408576698