Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2932453002: PlzNavigate: Release StreamHandle. (Closed)
Patch Set: Addressed comments (+Rebase) Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/frame_messages.h ('K') | « content/common/frame_messages.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index c595af5eaa1ce9775cc1bcd2c25e9b0be49b5cea..4248e8b52fe451dfd0c2a34bac7d65d51abdae17 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -5134,6 +5134,18 @@ void RenderFrameImpl::OnCommitNavigation(
stream_override->redirect_responses = request_params.redirect_response;
stream_override->redirect_infos = request_params.redirect_infos;
+ // PlzNavigate: Notify the browser that it can released its |stream_handle_|
clamy 2017/06/12 15:15:47 nit: no PlzNavigate needed (it's a full PlzNavigat
arthursonzogni 2017/06/13 09:21:48 Done.
+ // when the |stream_override| object is no more used. This is a temporary
+ // solution until mojo is used.
+ stream_override->on_delete = base::BindOnce(
+ [](base::WeakPtr<RenderFrameImpl> weak_self, const GURL& url) {
+ if (RenderFrameImpl* self = weak_self.get()) {
+ self->Send(
+ new FrameHostMsg_StreamHandleConsumed(self->routing_id_, url));
+ }
+ },
+ weak_factory_.GetWeakPtr());
+
if (commit_data.url_loader_factory.is_valid()) {
// Chrome doesn't use interface versioning.
url_loader_factory_.Bind(mojom::URLLoaderFactoryPtrInfo(
« content/common/frame_messages.h ('K') | « content/common/frame_messages.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698