PlzNavigate: Release StreamHandle.

content/browser/frame_host/render_frame_host_impl_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include "base/macros.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/frame_messages.h"
 #include "content/public/browser/javascript_dialog_manager.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/content_client.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "content/shell/browser/shell.h"
 #include "content/test/test_content_browser_client.h"
 
 namespace content {
 
@@ skipping 323 matching lines @@
   RenderFrameDeletedObserver deleted_observer(
       new_shell->web_contents()->GetMainFrame());
   deleted_observer.WaitUntilDeleted();
 
   bool is_closed = false;
   EXPECT_TRUE(ExecuteScriptAndExtractBool(
       shell(), "domAutomationController.send(popup.closed)", &is_closed));
   EXPECT_TRUE(is_closed);
 }
 
+// After a navigation, the StreamHandle must be released.
+IN_PROC_BROWSER_TEST_F(RenderFrameHostImplBrowserTest, StreamHandleReleased) {
+  EXPECT_TRUE(NavigateToURL(shell(), GetTestUrl("", "title1.html")));
+  WebContentsImpl* wc = static_cast<WebContentsImpl*>(shell()->web_contents());
+  RenderFrameHostImpl* main_frame =
+      static_cast<RenderFrameHostImpl*>(wc->GetMainFrame());
+  EXPECT_EQ(nullptr, main_frame->stream_handle_for_testing());
+}
+
+namespace {
+class DropStreamHandleConsumedFilter : public BrowserMessageFilter {
+ public:
+  DropStreamHandleConsumedFilter() : BrowserMessageFilter(FrameMsgStart) {}
+
+ protected:
+  ~DropStreamHandleConsumedFilter() override {}
+
+ private:
+  // BrowserMessageFilter:
+  bool OnMessageReceived(const IPC::Message& message) override {
+    return message.type() == FrameHostMsg_StreamHandleConsumed::ID;
+  }
+
+  DISALLOW_COPY_AND_ASSIGN(DropStreamHandleConsumedFilter);
+};
+}  // namespace
+
+// After a renderer crash, the StreamHandle must be released.
+IN_PROC_BROWSER_TEST_F(RenderFrameHostImplBrowserTest,
+                       StreamHandleReleasedOnRendererCrash) {
+  // |stream_handle_| is only used with PlzNavigate.
+  if (!IsBrowserSideNavigationEnabled())
+    return;
+
+  EXPECT_TRUE(NavigateToURL(shell(), GURL("about:blank")));

[nasko, 2017/06/13 16:53:43]

Why not navigate to a real URL, such as GetURL("/title1.html")?

[arthursonzogni, 2017/06/14 10:30:53]

It was because the embedded_test_server was not started.
I need to update the RenderFrameHostImplBrowserTest classe...
...Done.

+
+  // Set up a filter to make sure that the browser is not notified that its
+  // |stream_handle_| has been consumed.
+  WebContentsImpl* wc = static_cast<WebContentsImpl*>(shell()->web_contents());
+  RenderFrameHostImpl* main_frame =
+      static_cast<RenderFrameHostImpl*>(wc->GetMainFrame());
+  scoped_refptr<DropStreamHandleConsumedFilter> filter =
+      new DropStreamHandleConsumedFilter();
+  main_frame->GetProcess()->AddFilter(filter.get());
+
+  EXPECT_TRUE(NavigateToURL(shell(), GURL("data:text/html,hello")));

[nasko, 2017/06/13 16:53:43]

Same here, I think we are better off using an http(s) URL instead of data. Using
GetURL("/title2.html") will guarantee us that we don't do process swap,
therefore we can continue monitoring the same process.

[arthursonzogni, 2017/06/14 10:30:53]

Done.

+
+  // Check that the |stream_handle_| hasn't been released yet.
+  EXPECT_NE(nullptr, main_frame->stream_handle_for_testing());
+
+  // Make the renderer crash.
+  RenderProcessHost* renderer_process = main_frame->GetProcess();
+  RenderProcessHostWatcher crash_observer(
+      renderer_process, RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
+  renderer_process->Shutdown(0, false);
+  crash_observer.Wait();
+
+  // The |stream_handle_| must have been released now.
+  EXPECT_EQ(nullptr, main_frame->stream_handle_for_testing());
+}
+
 }  // namespace content