Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: Source/bindings/scripts/generate_bindings.pl

Issue 29323008: Fix IDL dependency computation for partial interfaces (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Reupload 4 Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/derived_sources.gyp ('k') | Source/build/scripts/list_idl_files_with_partial_interface.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/generate_bindings.pl
diff --git a/Source/bindings/scripts/generate_bindings.pl b/Source/bindings/scripts/generate_bindings.pl
index 06a8505791b4114615b3c7d68bec1596cf75435d..35c2a916498085f37ddced9c4ef66369898b650b 100755
--- a/Source/bindings/scripts/generate_bindings.pl
+++ b/Source/bindings/scripts/generate_bindings.pl
@@ -88,16 +88,18 @@ if ($interfaceDependenciesFile) {
}
close FH;
- # $additionalIdlFiles is list of IDL files which should not be included in
- # DerivedSources*.cpp (i.e. they are not described in the interface
- # dependencies file) but should generate .h and .cpp files.
+ # $additionalIdlFiles is for IDL files not listed in the interface
+ # dependencies file, namely generated IDL files for interfaces
+ # (not partial interfaces), so we need to generate .h and .cpp files.
if (!$idlFound and $additionalIdlFiles) {
my @idlFiles = shellwords($additionalIdlFiles);
$idlFound = grep { $_ and basename($_) eq basename($targetIdlFile) } @idlFiles;
}
if (!$idlFound) {
- # We generate empty .h and .cpp files just to tell build scripts that .h and .cpp files are created.
+ # IDL files for dependencies (partial interfaces and interfaces
+ # implemented elsewhere). We generate empty .h and .cpp files just to
+ # tell build scripts that outputs have been created.
generateEmptyHeaderAndCpp($targetInterfaceName, $outputDirectory);
exit 0;
}
« no previous file with comments | « Source/bindings/derived_sources.gyp ('k') | Source/build/scripts/list_idl_files_with_partial_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698