Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: Source/bindings/derived_sources.gyp

Issue 29323008: Fix IDL dependency computation for partial interfaces (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/build/scripts/list_idl_files_with_partial_interface.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # 1 #
2 # Copyright (C) 2013 Google Inc. All rights reserved. 2 # Copyright (C) 2013 Google Inc. All rights reserved.
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 'target_name': 'bindings_sources', 194 'target_name': 'bindings_sources',
195 'type': 'none', 195 'type': 'none',
196 # The 'binding' rule generates .h files, so mark as hard_dependency, per: 196 # The 'binding' rule generates .h files, so mark as hard_dependency, per:
197 # https://code.google.com/p/gyp/wiki/InputFormatReference#Linking_Dependen cies 197 # https://code.google.com/p/gyp/wiki/InputFormatReference#Linking_Dependen cies
198 'hard_dependency': 1, 198 'hard_dependency': 1,
199 'dependencies': [ 199 'dependencies': [
200 'interface_dependencies', 200 'interface_dependencies',
201 '../core/core_derived_sources.gyp:generate_test_support_idls', 201 '../core/core_derived_sources.gyp:generate_test_support_idls',
202 ], 202 ],
203 'sources': [ 203 'sources': [
204 '<@(main_idl_files)', 204 '<@(main_idl_files)',
kihong 2013/10/23 07:40:34 Don't we need to add support_idl_files here also?
Nils Barth (inactive) 2013/10/23 08:13:17 testing_support_idl_files includes support_idl_fil
205 '<@(testing_support_idl_files)', 205 '<@(testing_support_idl_files)',
206 ], 206 ],
207 'rules': [{ 207 'rules': [{
208 'rule_name': 'binding', 208 'rule_name': 'binding',
209 'extension': 'idl', 209 'extension': 'idl',
210 'msvs_external_rule': 1, 210 'msvs_external_rule': 1,
211 'inputs': [ 211 'inputs': [
212 'scripts/generate_bindings.pl', 212 'scripts/generate_bindings.pl',
213 'scripts/code_generator_v8.pm', 213 'scripts/code_generator_v8.pm',
214 'scripts/idl_parser.pm', 214 'scripts/idl_parser.pm',
215 'scripts/idl_serializer.pm', 215 'scripts/idl_serializer.pm',
216 '../build/scripts/preprocessor.pm', 216 '../build/scripts/preprocessor.pm',
217 'scripts/IDLAttributes.txt', 217 'scripts/IDLAttributes.txt',
218 # FIXME: If the dependency structure changes, we rebuild all files, 218 # FIXME: If the dependency structure changes, we rebuild all files,
219 # since we're not computing dependencies file-by-file in the build. 219 # since we're not computing dependencies file-by-file in the build.
220 '<(SHARED_INTERMEDIATE_DIR)/blink/InterfaceDependencies.txt', 220 '<(SHARED_INTERMEDIATE_DIR)/blink/InterfaceDependencies.txt',
221 # FIXME: Similarly, if any partial interface changes, rebuild 221 # FIXME: Similarly, if any partial interface changes, rebuild
222 # everything, since every IDL potentially depends on them, because 222 # everything, since every IDL potentially depends on them, because
223 # we're not computing dependencies file-by-file. 223 # we're not computing dependencies file-by-file.
224 # 224 #
225 # If a new partial interface is added, need to regyp to update these 225 # If a new partial interface is added, need to regyp to update these
226 # dependencies, as these are computed statically at gyp runtime. 226 # dependencies, as these are computed statically at gyp runtime.
227 '<!@pymod_do_main(list_idl_files_with_partial_interface <@(main_idl_fi les))', 227 '<!@pymod_do_main(list_idl_files_with_partial_interface <@(main_idl_fi les) <@(support_idl_files))',
228 # Generated IDLs are all partial interfaces, hence everything 228 # Generated IDLs are all partial interfaces, hence everything
229 # potentially depends on them. 229 # potentially depends on them.
230 '<@(generated_global_constructors_idl_files)', 230 '<@(generated_global_constructors_idl_files)',
231 ], 231 ],
232 'outputs': [ 232 'outputs': [
233 '<(bindings_output_dir)/V8<(RULE_INPUT_ROOT).cpp', 233 '<(bindings_output_dir)/V8<(RULE_INPUT_ROOT).cpp',
234 '<(bindings_output_dir)/V8<(RULE_INPUT_ROOT).h', 234 '<(bindings_output_dir)/V8<(RULE_INPUT_ROOT).h',
235 ], 235 ],
236 'variables': { 236 'variables': {
237 # IDL include paths. The generator will search recursively for IDL 237 # IDL include paths. The generator will search recursively for IDL
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 '../build/scripts/action_derivedsourcesallinone.py', 293 '../build/scripts/action_derivedsourcesallinone.py',
294 '<(SHARED_INTERMEDIATE_DIR)/blink/BindingsDerivedSources.txt', 294 '<(SHARED_INTERMEDIATE_DIR)/blink/BindingsDerivedSources.txt',
295 '--', 295 '--',
296 '<@(derived_sources_aggregate_files)', 296 '<@(derived_sources_aggregate_files)',
297 ], 297 ],
298 'message': 'Generating bindings derived sources', 298 'message': 'Generating bindings derived sources',
299 }], 299 }],
300 }, 300 },
301 ], 301 ],
302 } 302 }
OLDNEW
« no previous file with comments | « no previous file | Source/build/scripts/list_idl_files_with_partial_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698