Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: ui/views/window/dialog_delegate.cc

Issue 2932243002: Refactor ChooserDialogView to use borders instead of content margins. (Closed)
Patch Set: nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/window/dialog_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/window/dialog_delegate.cc
diff --git a/ui/views/window/dialog_delegate.cc b/ui/views/window/dialog_delegate.cc
index b02a8048ccf92c598b2204e799863ddef6d38b0f..0acad06b42ba6e5e89208cfa6be6935ceaa8d939 100644
--- a/ui/views/window/dialog_delegate.cc
+++ b/ui/views/window/dialog_delegate.cc
@@ -194,17 +194,15 @@ ClientView* DialogDelegate::CreateClientView(Widget* widget) {
NonClientFrameView* DialogDelegate::CreateNonClientFrameView(Widget* widget) {
if (ShouldUseCustomFrame())
- return CreateDialogFrameView(widget, gfx::Insets());
+ return CreateDialogFrameView(widget);
return WidgetDelegate::CreateNonClientFrameView(widget);
}
// static
-NonClientFrameView* DialogDelegate::CreateDialogFrameView(
- Widget* widget,
- const gfx::Insets& content_margins) {
+NonClientFrameView* DialogDelegate::CreateDialogFrameView(Widget* widget) {
BubbleFrameView* frame = new BubbleFrameView(
LayoutProvider::Get()->GetInsetsMetric(INSETS_DIALOG_TITLE),
- content_margins);
+ gfx::Insets());
const BubbleBorder::Shadow kShadow = BubbleBorder::SMALL_SHADOW;
std::unique_ptr<BubbleBorder> border(
new BubbleBorder(BubbleBorder::FLOAT, kShadow, gfx::kPlaceholderColor));
« no previous file with comments | « ui/views/window/dialog_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698