Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4581)

Unified Diff: chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

Issue 2932243002: Refactor ChooserDialogView to use borders instead of content margins. (Closed)
Patch Set: nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/extensions/chooser_dialog_view.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc
diff --git a/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..34b2d90e8e439c6e28f2b92c9dd6e226aff050f7
--- /dev/null
+++ b/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc
@@ -0,0 +1,63 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/extensions/chooser_dialog_view.h"
+
+#include <string>
+
+#include "base/command_line.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/chooser_controller/mock_chooser_controller.h"
+#include "chrome/browser/platform_util.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/test/test_browser_dialog.h"
+#include "components/constrained_window/constrained_window_views.h"
+#include "components/web_modal/web_contents_modal_dialog_manager.h"
+
+// Invokes the device chooser dialog with mock content. See
+// test_browser_dialog.h.
+class ChooserDialogViewBrowserTest : public DialogBrowserTest {
+ public:
+ ChooserDialogViewBrowserTest() : controller_(new MockChooserController()) {}
+
+ // DialogBrowserTest:
+ void ShowDialog(const std::string& name) override {
+ auto* web_contents = browser()->tab_strip_model()->GetActiveWebContents();
+ web_modal::WebContentsModalDialogManager* manager =
+ web_modal::WebContentsModalDialogManager::FromWebContents(web_contents);
+ if (manager) {
+ constrained_window::ShowWebModalDialogViews(
+ new ChooserDialogView(std::move(controller_)), web_contents);
+ }
+ }
+
+ MockChooserController& controller() { return *controller_; }
+
+ private:
+ std::unique_ptr<MockChooserController> controller_;
+
+ DISALLOW_COPY_AND_ASSIGN(ChooserDialogViewBrowserTest);
+};
+
+IN_PROC_BROWSER_TEST_F(ChooserDialogViewBrowserTest, InvokeDialog_noDevices) {
+ RunDialog();
+}
+
+IN_PROC_BROWSER_TEST_F(ChooserDialogViewBrowserTest, InvokeDialog_withDevices) {
+ controller().OptionAdded(base::ASCIIToUTF16("Device 1"),
+ MockChooserController::kNoSignalStrengthLevelImage,
+ MockChooserController::NONE);
+ controller().OptionAdded(base::ASCIIToUTF16("Device 2"),
+ MockChooserController::kSignalStrengthLevel2Bar,
+ MockChooserController::PAIRED);
+ controller().OptionAdded(base::ASCIIToUTF16("Device 3"),
+ MockChooserController::kSignalStrengthLevel4Bar,
+ MockChooserController::CONNECTED);
+ controller().OptionAdded(
+ base::ASCIIToUTF16("Device 4"),
+ MockChooserController::kSignalStrengthLevel1Bar,
+ MockChooserController::PAIRED | MockChooserController::CONNECTED);
+ RunDialog();
+}
« no previous file with comments | « chrome/browser/ui/views/extensions/chooser_dialog_view.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698