Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: testing/scripts/check_gn_headers.py

Issue 2932153002: Print detailed info in check_gn_headers.py (Closed)
Patch Set: lint Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/check_gn_headers_unittest.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2017 The Chromium Authors. All rights reserved. 2 # Copyright 2017 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import json 6 import json
7 import os 7 import os
8 import sys 8 import sys
9 9
10 10
11 import common 11 import common
12 12
13 13
14 def main_run(args): 14 def main_run(args):
15 with common.temporary_file() as tempfile_path: 15 with common.temporary_file() as tempfile_path:
16 rc = common.run_command([ 16 rc = common.run_command([
17 sys.executable, 17 sys.executable,
18 os.path.join(common.SRC_DIR, 'build', 'check_gn_headers.py'), 18 os.path.join(common.SRC_DIR, 'build', 'check_gn_headers.py'),
19 '--out-dir', 19 '--out-dir',
20 os.path.join(args.paths['checkout'], 'out', args.build_config_fs), 20 os.path.join(args.paths['checkout'], 'out', args.build_config_fs),
21 '--whitelist', 21 '--whitelist',
22 os.path.join(common.SRC_DIR, 'build', 'check_gn_headers_whitelist.txt'), 22 os.path.join(common.SRC_DIR, 'build', 'check_gn_headers_whitelist.txt'),
23 '--json', tempfile_path 23 '--json', tempfile_path,
24 '--verbose',
24 ], cwd=common.SRC_DIR) 25 ], cwd=common.SRC_DIR)
25 26
26 with open(tempfile_path) as f: 27 with open(tempfile_path) as f:
27 failures = json.load(f) 28 failures = json.load(f)
28 29
29 json.dump({ 30 json.dump({
30 'valid': True, 31 'valid': True,
31 'failures': failures, 32 'failures': failures,
32 }, args.output) 33 }, args.output)
33 34
34 return rc 35 return rc
35 36
36 37
37 def main_compile_targets(args): 38 def main_compile_targets(args):
38 json.dump([], args.output) 39 json.dump([], args.output)
39 40
40 41
41 if __name__ == '__main__': 42 if __name__ == '__main__':
42 funcs = { 43 funcs = {
43 'run': main_run, 44 'run': main_run,
44 'compile_targets': main_compile_targets, 45 'compile_targets': main_compile_targets,
45 } 46 }
46 sys.exit(common.run_script(sys.argv[1:], funcs)) 47 sys.exit(common.run_script(sys.argv[1:], funcs))
OLDNEW
« no previous file with comments | « build/check_gn_headers_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698