Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: pkg/compiler/lib/src/ssa/locals_handler.dart

Issue 2932023003: Refactor LoopHandler to avoid calling KernelAstAdapter.getNode (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/locals_handler.dart
diff --git a/pkg/compiler/lib/src/ssa/locals_handler.dart b/pkg/compiler/lib/src/ssa/locals_handler.dart
index 2d62f9131b094e085c2a2414a5a1425aeb8fd818..6ab5aa1a5fef2bb2992a343c276c284d3bbe60b8 100644
--- a/pkg/compiler/lib/src/ssa/locals_handler.dart
+++ b/pkg/compiler/lib/src/ssa/locals_handler.dart
@@ -473,8 +473,8 @@ class LocalsHandler {
/// <updates>
/// goto loop-entry;
/// loop-exit:
- void startLoop(ast.Node node) {
- ClosureScope scopeData = closureData.capturingScopes[node];
+ void startLoop(ClosureScope scopeData) {
+ //ClosureScope scopeData = closureData.capturingScopes[node];
Emily Fortuna 2017/06/09 20:12:27 delete line?
if (scopeData == null) return;
if (scopeData.hasBoxedLoopVariables()) {
// If there are boxed loop variables then we set up the box and
@@ -508,8 +508,8 @@ class LocalsHandler {
});
}
- void enterLoopBody(ast.Node node) {
- ClosureScope scopeData = closureData.capturingScopes[node];
+ void enterLoopBody(ClosureScope scopeData) {
+ //ClosureScope scopeData = closureData.capturingScopes[node];
Emily Fortuna 2017/06/09 20:12:27 same here
if (scopeData == null) return;
// If there are no declared boxed loop variables then we did not create the
// box before the initializer and we have to create the box now.
@@ -518,13 +518,13 @@ class LocalsHandler {
}
}
- void enterLoopUpdates(ast.Node node) {
+ void enterLoopUpdates(ClosureScope scopeData) {
// If there are declared boxed loop variables then the updates might have
// access to the box and we must switch to a new box before executing the
// updates.
// In all other cases a new box will be created when entering the body of
// the next iteration.
- ClosureScope scopeData = closureData.capturingScopes[node];
+ //ClosureScope scopeData = closureData.capturingScopes[node];
Emily Fortuna 2017/06/09 20:12:27 ditto
if (scopeData == null) return;
if (scopeData.hasBoxedLoopVariables()) {
updateCaptureBox(scopeData.boxElement, scopeData.boxedLoopVariables);

Powered by Google App Engine
This is Rietveld 408576698