Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: chrome/browser/cocoa/tab_view_picker_table_unittest.mm

Issue 2932009: Mac: Tweak content settings window. (Closed)
Patch Set: fffffffffffffffff Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/tab_view_picker_table.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/tab_view_picker_table_unittest.mm
diff --git a/chrome/browser/cocoa/tab_view_picker_table_unittest.mm b/chrome/browser/cocoa/tab_view_picker_table_unittest.mm
index 08459d2da37e8a4ba0566ebee6bf4dee68acbee4..00440fee6d22c9142e75338617da368000b61e9c 100644
--- a/chrome/browser/cocoa/tab_view_picker_table_unittest.mm
+++ b/chrome/browser/cocoa/tab_view_picker_table_unittest.mm
@@ -95,16 +95,20 @@ TEST_F(TabViewPickerTableTest, TestDelegateStillWorks) {
TEST_F(TabViewPickerTableTest, RowsCorrect) {
EXPECT_EQ(2, [view_ numberOfRows]);
- EXPECT_EQ(2, [[view_ dataSource] numberOfRowsInTableView:view_]);
+ EXPECT_EQ(2,
+ [[view_ dataSource] outlineView:view_ numberOfChildrenOfItem:nil]);
+ id item;
+ item = [[view_ dataSource] outlineView:view_ child:0 ofItem:nil];
EXPECT_TRUE([@"label 1" isEqualToString:[[view_ dataSource]
- tableView:view_
+ outlineView:view_
objectValueForTableColumn:nil // ignored
- row:0]]);
+ byItem:item]]);
+ item = [[view_ dataSource] outlineView:view_ child:1 ofItem:nil];
EXPECT_TRUE([@"label 2" isEqualToString:[[view_ dataSource]
- tableView:view_
+ outlineView:view_
objectValueForTableColumn:nil // ignored
- row:1]]);
+ byItem:item]]);
}
TEST_F(TabViewPickerTableTest, TestListUpdatesTabView) {
@@ -114,4 +118,20 @@ TEST_F(TabViewPickerTableTest, TestListUpdatesTabView) {
EXPECT_EQ(0, [tabView_ indexOfTabViewItem:[tabView_ selectedTabViewItem]]);
}
+TEST_F(TabViewPickerTableTest, TestWithHeadingNotEmpty) {
+ [view_ setHeading:@"disregard this"];
+
+ EXPECT_EQ(2, [view_ selectedRow]);
+
+ [tabView_ selectTabViewItemAtIndex:0];
+ EXPECT_EQ(1, [view_ selectedRow]);
+ [tabView_ selectTabViewItemAtIndex:1];
+ EXPECT_EQ(2, [view_ selectedRow]);
+
+ [view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:1]
+ byExtendingSelection:NO];
+ EXPECT_EQ(1, [view_ selectedRow]); // sanity
+ EXPECT_EQ(0, [tabView_ indexOfTabViewItem:[tabView_ selectedTabViewItem]]);
+}
+
} // namespace
« no previous file with comments | « chrome/browser/cocoa/tab_view_picker_table.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698