Issue 2932007: Use WebCore's built in support for user styles

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2932007: Use WebCore's built in support for user styles (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Aaron Boodman

Modified:
3 years, 11 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Use WebCore's built in support for user styles instead of the hack we were doing before. This has a side-effect of fixing a bunch of content-interaction bugs because we will be using real user-level styles (in the CSS sense) rather than content-level styles. BUG=29995 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52581 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52584

Patch Set 1 #

Patch Set 2 : comments #

Total comments: 2

Patch Set 3 : whoops #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -17 lines)			Patch
M	chrome/common/extensions/url_pattern.h	View	1	3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/url_pattern.cc	View	1 2	3 chunks	+29 lines, -7 lines	0 comments	Download
M	chrome/common/extensions/url_pattern_unittest.cc	View		11 chunks	+40 lines, -0 lines	0 comments	Download
M	chrome/renderer/user_script_slave.cc	View	1	3 chunks	+45 lines, -10 lines	0 comments	Download

Trybot results: mac linux

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

woot On Fri, Jul 9, 2010 at 4:24 PM, <aa@chromium.org> wrote: > Reviewers: Matt Perry, ...

4 years, 10 months ago (2010-07-09 23:31:57 UTC) #2

Matt Perry

4 years, 10 months ago (2010-07-09 23:32:43 UTC) #3

lgtm with small issues fixed

http://codereview.chromium.org/2932007/diff/2001/3002
File chrome/common/extensions/url_pattern.h (right):

http://codereview.chromium.org/2932007/diff/2001/3002#newcode163
chrome/common/extensions/url_pattern.h:163: // Conver this URLPattern into an
equivalent set of URLPatterns that don't use
convert

http://codereview.chromium.org/2932007/diff/2001/3004
File chrome/renderer/user_script_slave.cc (right):

http://codereview.chromium.org/2932007/diff/2001/3004#newcode166
chrome/renderer/user_script_slave.cc:166: script->match_all_frames() ?
indent

Expand Messages | Collapse Messages