Implement nextHopProtocol in PerformanceResourceTiming and PerformanceNavigationTiming.

third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 39 matching lines @@
                        "resource",
                        PerformanceBase::MonotonicTimeToDOMHighResTimeStamp(
                            time_origin,
                            start_time,
                            info.NegativeAllowed()),
                        PerformanceBase::MonotonicTimeToDOMHighResTimeStamp(
                            time_origin,
                            info.LoadFinishTime(),
                            info.NegativeAllowed())),
       initiator_type_(info.InitiatorType()),
+      alpn_negotiated_protocol_(info.FinalResponse().AlpnNegotiatedProtocol()),
+      connection_info_(info.FinalResponse().ConnectionInfoString()),
       time_origin_(time_origin),
       timing_(info.FinalResponse().GetResourceLoadTiming()),
       last_redirect_end_time_(last_redirect_end_time),
       finish_time_(info.LoadFinishTime()),
       transfer_size_(info.TransferSize()),
       encoded_body_size_(info.FinalResponse().EncodedBodyLength()),
       decoded_body_size_(info.FinalResponse().DecodedBodyLength()),
       did_reuse_connection_(info.FinalResponse().ConnectionReused()),
       allow_timing_details_(allow_timing_details),
       allow_redirect_details_(allow_redirect_details),
@@ skipping 29 matching lines @@
 }
 
 unsigned long long PerformanceResourceTiming::GetDecodedBodySize() const {
   return decoded_body_size_;
 }
 
 AtomicString PerformanceResourceTiming::initiatorType() const {
   return initiator_type_;
 }
 
+AtomicString PerformanceResourceTiming::AlpnNegotiatedProtocol() const {
+  return alpn_negotiated_protocol_;
+}
+
+AtomicString PerformanceResourceTiming::ConnectionInfo() const {
+  return connection_info_;
+}
+
+AtomicString PerformanceResourceTiming::GetNextHopProtocol(
+    const AtomicString& alpn_negotiated_protocol,
+    const AtomicString& connection_info) {
+  // Fallback to connection_info when alpn_negotiated_protocol is unknown.
+  AtomicString returnedProtocol = (alpn_negotiated_protocol == "unknown")
+                                      ? connection_info
+                                      : alpn_negotiated_protocol;
+  // If connection_info is also unknown, return empty string.
+  // (https://github.com/w3c/navigation-timing/issues/71)

[Yoav Weiss, 2017/06/16 15:25:04]

This probably should be documented elsewhere, but no point in holding off this
patch until that happens. Maybe add a TODO to update the spec pointers?

[panicker, 2017/06/16 22:41:17]

What else is there to document exactly (and which spec pointer)? I opened that
github to document the fallback case, and it's been resolved AFAICT.

+  returnedProtocol = (returnedProtocol == "unknown") ? "" : returnedProtocol;
+  // If the protocol is http over quic (e.g. http/2+quic/37), convert it to the
+  // alpn id "hq". (https://github.com/w3c/navigation-timing/issues/71)

[Yoav Weiss, 2017/06/16 15:25:04]

I don't think we should convert Google's QUIC into "hq" here. See
https://github.com/w3c/navigation-timing/issues/71#issuecomment-309054561

[panicker, 2017/06/16 17:37:27]

What are you proposing instead?
I'm fine with starting with blank string until we can decide; we already had
tons of back and forth on this and I'd like to unblock the rest of this CL.

[panicker, 2017/06/16 22:41:17]

As Ilya suggested on bug, let's stick with "hq" and feel free to start a thread
on blink-dev with sleevi@ if you have reservations. 

+  if (returnedProtocol.Contains("quic"))
+    returnedProtocol = "hq";
+
+  return returnedProtocol;
+}
+
+AtomicString PerformanceResourceTiming::nextHopProtocol() const {
+  return PerformanceResourceTiming::GetNextHopProtocol(AlpnNegotiatedProtocol(),
+                                                       ConnectionInfo());
+}
+
 DOMHighResTimeStamp PerformanceResourceTiming::workerStart() const {
   ResourceLoadTiming* timing = GetResourceLoadTiming();
   if (!timing || timing->WorkerStart() == 0.0)
     return 0.0;
 
   return PerformanceBase::MonotonicTimeToDOMHighResTimeStamp(
       time_origin_, timing->WorkerStart(), allow_negative_value_);
 }
 
 DOMHighResTimeStamp PerformanceResourceTiming::WorkerReady() const {
@@ skipping 151 matching lines @@
 unsigned long long PerformanceResourceTiming::decodedBodySize() const {
   if (!AllowTimingDetails())
     return 0;
 
   return GetDecodedBodySize();
 }
 
 void PerformanceResourceTiming::BuildJSONValue(V8ObjectBuilder& builder) const {
   PerformanceEntry::BuildJSONValue(builder);
   builder.AddString("initiatorType", initiatorType());
+  builder.AddString("nextHopProtocol", nextHopProtocol());
   builder.AddNumber("workerStart", workerStart());
   builder.AddNumber("redirectStart", redirectStart());
   builder.AddNumber("redirectEnd", redirectEnd());
   builder.AddNumber("fetchStart", fetchStart());
   builder.AddNumber("domainLookupStart", domainLookupStart());
   builder.AddNumber("domainLookupEnd", domainLookupEnd());
   builder.AddNumber("connectStart", connectStart());
   builder.AddNumber("connectEnd", connectEnd());
   builder.AddNumber("secureConnectionStart", secureConnectionStart());
   builder.AddNumber("requestStart", requestStart());
   builder.AddNumber("responseStart", responseStart());
   builder.AddNumber("responseEnd", responseEnd());
   builder.AddNumber("transferSize", transferSize());
   builder.AddNumber("encodedBodySize", encodedBodySize());
   builder.AddNumber("decodedBodySize", decodedBodySize());
 }
 
 }  // namespace blink