Chromium Code Reviews| Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h |
| diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h |
| index a640e770605d083bca3405f2fa66e7b06c93e73d..6865b5e16f1cdec2dabd5cf3753750c609e8e3f6 100644 |
| --- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h |
| +++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h |
| @@ -272,12 +272,11 @@ class WebServiceWorkerContextClient { |
| // should delete the callbacks after calling either onSuccess or onError. |
| // WebServiceWorkerClientInfo and WebServiceWorkerError ownerships are |
| // passed to the WebServiceWorkerClientsCallbacks implementation. |
| - virtual void OpenWindowForClients( |
| - const WebURL&, |
| - std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0; |
| + virtual void OpenNewTab(const WebURL&, |
| + std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0; |
| - // Similar like OpenWindowForClients above. |
| - virtual void OpenWindowForPaymentHandler( |
| + // Similar like OpenNewTab above. |
|
dcheng
2017/06/08 20:43:55
Nit: Similar to
gogerald1
2017/06/09 01:52:12
Done.
|
| + virtual void OpenNewPopup( |
| const WebURL&, |
| std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0; |