Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: runtime/vm/profiler.cc

Issue 2931933002: [fuchsia] Update profiler assertions to allow for profiler running on a different thread. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/stack_frame.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/address_sanitizer.h" 5 #include "platform/address_sanitizer.h"
6 #include "platform/memory_sanitizer.h" 6 #include "platform/memory_sanitizer.h"
7 #include "platform/utils.h" 7 #include "platform/utils.h"
8 8
9 #include "vm/allocation.h" 9 #include "vm/allocation.h"
10 #include "vm/atomic.h" 10 #include "vm/atomic.h"
(...skipping 433 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 sample, 444 sample,
445 sample_buffer, 445 sample_buffer,
446 skip_count), 446 skip_count),
447 pc_(reinterpret_cast<uword*>(pc)), 447 pc_(reinterpret_cast<uword*>(pc)),
448 fp_(reinterpret_cast<uword*>(fp)), 448 fp_(reinterpret_cast<uword*>(fp)),
449 sp_(reinterpret_cast<uword*>(sp)), 449 sp_(reinterpret_cast<uword*>(sp)),
450 stack_upper_(stack_upper), 450 stack_upper_(stack_upper),
451 stack_lower_(stack_lower), 451 stack_lower_(stack_lower),
452 has_exit_frame_(exited_dart_code) { 452 has_exit_frame_(exited_dart_code) {
453 if (exited_dart_code) { 453 if (exited_dart_code) {
454 // On windows the profiler does not run on the thread being profiled. 454 // On Windows and Fuchsia the profiler does not run on the thread being
455 #if defined(_WIN32) 455 // profiled.
456 #if defined(HOST_OS_WINDOWS) || defined(HOST_OS_FUCHSIA)
456 const StackFrameIterator::CrossThreadPolicy cross_thread_policy = 457 const StackFrameIterator::CrossThreadPolicy cross_thread_policy =
457 StackFrameIterator::kAllowCrossThreadIteration; 458 StackFrameIterator::kAllowCrossThreadIteration;
458 #else 459 #else
459 const StackFrameIterator::CrossThreadPolicy cross_thread_policy = 460 const StackFrameIterator::CrossThreadPolicy cross_thread_policy =
460 StackFrameIterator::kNoCrossThreadIteration; 461 StackFrameIterator::kNoCrossThreadIteration;
461 #endif 462 #endif
462 StackFrameIterator iterator(StackFrameIterator::kDontValidateFrames, 463 StackFrameIterator iterator(StackFrameIterator::kDontValidateFrames,
463 thread, cross_thread_policy); 464 thread, cross_thread_policy);
464 pc_ = NULL; 465 pc_ = NULL;
465 fp_ = NULL; 466 fp_ = NULL;
(...skipping 1146 matching lines...) Expand 10 before | Expand all | Expand 10 after
1612 1613
1613 1614
1614 ProcessedSampleBuffer::ProcessedSampleBuffer() 1615 ProcessedSampleBuffer::ProcessedSampleBuffer()
1615 : code_lookup_table_(new CodeLookupTable(Thread::Current())) { 1616 : code_lookup_table_(new CodeLookupTable(Thread::Current())) {
1616 ASSERT(code_lookup_table_ != NULL); 1617 ASSERT(code_lookup_table_ != NULL);
1617 } 1618 }
1618 1619
1619 #endif // !PRODUCT 1620 #endif // !PRODUCT
1620 1621
1621 } // namespace dart 1622 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/stack_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698