Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2931933002: [fuchsia] Update profiler assertions to allow for profiler running on a different thread. (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[fuchsia] Update profiler assertions to allow for profiler running on a different thread. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/b1da119a5eea9ab7fe6cd66f6b522c171ea8e5b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M runtime/vm/profiler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/stack_frame.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 6 months ago (2017-06-08 18:30:05 UTC) #2
zra
lgtm
3 years, 6 months ago (2017-06-08 19:12:46 UTC) #3
rmacnak
3 years, 6 months ago (2017-06-08 19:28:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1da119a5eea9ab7fe6cd66f6b522c171ea8e5b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698