build/android/chrome_profiler/profiler.py - Issue 293193002: adb_profile_chrome: Add perf profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/chrome_profiler/profiler.py

Issue 293193002: adb_profile_chrome: Add perf profiler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/chrome_profiler/profiler.py

diff --git a/build/android/chrome_profiler/profiler.py b/build/android/chrome_profiler/profiler.py

index 019d3c02a55a5781c0b3587655520fa41fa34113..ed634a4435601115b4d397c6d1bb55d8dcb7c4c1 100644

--- a/build/android/chrome_profiler/profiler.py

+++ b/build/android/chrome_profiler/profiler.py

@@ -53,9 +53,7 @@ def _StopTracing(controllers):

def _PullTraces(controllers, output, compress, write_json):

ui.PrintMessage('Downloading...', eol='')

- trace_files = []

- for controller in controllers:

- trace_files.append(controller.PullTrace())

+ trace_files = [controller.PullTrace() for controller in controllers]

if not write_json:

html_file = os.path.splitext(trace_files[0])[0] + '.html'