Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2931903003: Get the name and message from DOMException correctly (Closed)

Created:
3 years, 6 months ago by Alan Knight
Modified:
3 years, 6 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -20 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +6 lines, -10 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DOMException.darttemplate View 2 chunks +5 lines, -10 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Alan Knight
I also deleted some code that looks pretty definitely dead in the template.
3 years, 6 months ago (2017-06-08 23:47:57 UTC) #2
Jacob
lgtm https://codereview.chromium.org/2931903003/diff/1/tools/dom/templates/html/impl/impl_DOMException.darttemplate File tools/dom/templates/html/impl/impl_DOMException.darttemplate (left): https://codereview.chromium.org/2931903003/diff/1/tools/dom/templates/html/impl/impl_DOMException.darttemplate#oldcode52 tools/dom/templates/html/impl/impl_DOMException.darttemplate:52: @Deprecated("Internal Use Only") probably dead but do a ...
3 years, 6 months ago (2017-06-08 23:50:00 UTC) #3
Alan Knight
On 2017/06/08 23:50:00, Jacob wrote: > lgtm > > https://codereview.chromium.org/2931903003/diff/1/tools/dom/templates/html/impl/impl_DOMException.darttemplate > File tools/dom/templates/html/impl/impl_DOMException.darttemplate (left): > ...
3 years, 6 months ago (2017-06-08 23:56:42 UTC) #4
terry
lgtm
3 years, 6 months ago (2017-06-13 15:50:30 UTC) #5
Alan Knight
3 years, 6 months ago (2017-06-13 15:59:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6042ae4bd8be9c8bacafac3ce62990f6b29601b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698