More precise use of multiline state

content/browser/accessibility/browser_accessibility.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/browser_accessibility.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <iterator>
@@ skipping 110 matching lines @@
 
   if (this == ancestor)
     return true;
 
   if (PlatformGetParent())
     return PlatformGetParent()->IsDescendantOf(ancestor);
 
   return false;
 }
 
+bool BrowserAccessibility::IsDocument() const {

[dougt, 2017/06/30 22:03:30]

Please do not add more simple predicates here.  Instead add them to
ax_role_properties.*

+  return GetRole() == ui::AX_ROLE_ROOT_WEB_AREA ||
+         GetRole() == ui::AX_ROLE_WEB_AREA;
+}
+
 bool BrowserAccessibility::IsTextOnlyObject() const {
   return GetRole() == ui::AX_ROLE_STATIC_TEXT ||
          GetRole() == ui::AX_ROLE_LINE_BREAK ||
          GetRole() == ui::AX_ROLE_INLINE_TEXT_BOX;
 }
 
 bool BrowserAccessibility::IsLineBreakObject() const {
   return GetRole() == ui::AX_ROLE_LINE_BREAK ||
          (IsTextOnlyObject() && PlatformGetParent() &&
           PlatformGetParent()->GetRole() == ui::AX_ROLE_LINE_BREAK);
@@ skipping 810 matching lines @@
     if (!GetHtmlAttribute("type", &input_type))
       return true;
     return input_type.empty() || input_type == "email" ||
            input_type == "password" || input_type == "search" ||
            input_type == "tel" || input_type == "text" || input_type == "url" ||
            input_type == "number";
   }
   return html_tag == "textarea";
 }
 
+// In general we should use IsEditField() instead if we want to check for
+// something that has a caret and the user can edit.
+// TODO(aleventhal) this name is confusing because it returns true for combobox,
+// and we should take a look at why a combobox is considered a text control. The
+// ARIA spec says a combobox would contain (but not be) a text field. It looks
+// like a mistake may have been made in that comboboxes have been considered a
+// kind of textbox. Find an appropriate name for this function, and consider
+// returning false for comboboxes it doesn't break existing websites.
 bool BrowserAccessibility::IsSimpleTextControl() const {
   // Time fields, color wells and spinner buttons might also use text fields as
   // constituent parts, but they are not considered text fields as a whole.
   switch (GetRole()) {
     case ui::AX_ROLE_COMBO_BOX:
     case ui::AX_ROLE_SEARCH_BOX:
       return true;
     case ui::AX_ROLE_TEXT_FIELD:
       return !HasState(ui::AX_STATE_RICHLY_EDITABLE);
     default:
       return false;
   }
 }
 
+bool BrowserAccessibility::IsEditField() const {

[dougt, 2017/06/30 22:03:30]

Same.

+  return GetRole() == ui::AX_ROLE_TEXT_FIELD ||
+         GetRole() == ui::AX_ROLE_SEARCH_BOX;
+}
+
 // Indicates if this object is at the root of a rich edit text control.
 bool BrowserAccessibility::IsRichTextControl() const {
   return HasState(ui::AX_STATE_RICHLY_EDITABLE) &&
          (!PlatformGetParent() ||
           !PlatformGetParent()->HasState(ui::AX_STATE_RICHLY_EDITABLE));
 }
 
 bool BrowserAccessibility::HasExplicitlyEmptyName() const {
   return GetIntAttribute(ui::AX_ATTR_NAME_FROM) ==
          ui::AX_NAME_FROM_ATTRIBUTE_EXPLICITLY_EMPTY;
@@ skipping 175 matching lines @@
   return false;
 }
 
 bool BrowserAccessibility::ShouldIgnoreHoveredStateForTesting() {
   BrowserAccessibilityStateImpl* accessibility_state =
       BrowserAccessibilityStateImpl::GetInstance();
   return accessibility_state->disable_hot_tracking_for_testing();
 }
 
 }  // namespace content