Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: milo/appengine/buildbot/pubsub_test.go

Issue 2931773004: Milo: Add machine pool info for buildbot builder view. (Closed)
Patch Set: Review Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbot/master.go ('k') | milo/appengine/common/funcs.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbot/pubsub_test.go
diff --git a/milo/appengine/buildbot/pubsub_test.go b/milo/appengine/buildbot/pubsub_test.go
index 8fd1992a5fcdea6d2a18ea3a7e190d955d2e1d81..b261f225b8335f488459c908c07827fcf6501497 100644
--- a/milo/appengine/buildbot/pubsub_test.go
+++ b/milo/appengine/buildbot/pubsub_test.go
@@ -113,7 +113,7 @@ func TestPubSub(t *testing.T) {
},
}
So(putDSMasterJSON(c, m, false), ShouldBeNil)
- lm, _, err := getMasterJSON(c, "fake")
+ lm, _, _, err := getMasterJSON(c, "fake")
So(err, ShouldBeNil)
So(lm.Builders["fake builder"].PendingBuildStates[0].Source.Changes[0].Comments, ShouldResemble, "")
})
@@ -258,7 +258,7 @@ func TestPubSub(t *testing.T) {
So(err, ShouldBeNil)
So(loadB.Master, ShouldEqual, "Fake Master")
So(loadB.Currentstep.(string), ShouldEqual, "this is a string")
- m, t, err := getMasterJSON(c, "Fake Master")
+ m, _, t, err := getMasterJSON(c, "Fake Master")
So(err, ShouldBeNil)
So(t.Unix(), ShouldEqual, 981173106)
So(m.Name, ShouldEqual, "Fake Master")
@@ -284,7 +284,7 @@ func TestPubSub(t *testing.T) {
Params: p,
})
So(h.Code, ShouldEqual, 200)
- m, t, err := getMasterJSON(c, "Fake Master")
+ m, _, t, err := getMasterJSON(c, "Fake Master")
So(err, ShouldBeNil)
So(m.Project.Title, ShouldEqual, "some other title")
So(t.Unix(), ShouldEqual, 981173107)
@@ -478,7 +478,7 @@ func TestPubSub(t *testing.T) {
So(loadB.Master, ShouldEqual, "Fake Master")
So(loadB.Internal, ShouldEqual, true)
So(loadB.Currentstep.(string), ShouldEqual, "this is a string")
- m, t, err := getMasterJSON(c, "Fake Master")
+ m, _, t, err := getMasterJSON(c, "Fake Master")
So(err, ShouldBeNil)
So(t.Unix(), ShouldEqual, 981173106)
So(m.Name, ShouldEqual, "Fake Master")
« no previous file with comments | « milo/appengine/buildbot/master.go ('k') | milo/appengine/common/funcs.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698