Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 2931773002: DevTools: kill DebuggerWorkspaceBinding.{push,pop,set}SourceMapping (Closed)
Patch Set: address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
index 233e9e3d6446f90dce91446b575db99e946a7ec4..977685711778379b32d1a804f7e2d3a00cb5fc43 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
@@ -56,8 +56,6 @@ Bindings.BreakpointManager = class extends Common.Object {
this._workspace.addEventListener(Workspace.Workspace.Events.ProjectRemoved, this._projectRemoved, this);
this._workspace.addEventListener(Workspace.Workspace.Events.UISourceCodeAdded, this._uiSourceCodeAdded, this);
this._workspace.addEventListener(Workspace.Workspace.Events.UISourceCodeRemoved, this._uiSourceCodeRemoved, this);
- this._debuggerWorkspaceBinding.addEventListener(
- Bindings.DebuggerWorkspaceBinding.Events.SourceMappingChanged, this._uiSourceCodeMappingChanged, this);
targetManager.observeModels(SDK.DebuggerModel, this);
}
@@ -172,20 +170,6 @@ Bindings.BreakpointManager = class extends Common.Object {
this._removeUISourceCode(uiSourceCode);
}
- /**
- * @param {!Common.Event} event
- */
- _uiSourceCodeMappingChanged(event) {
- var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (event.data.uiSourceCode);
- var isIdentity = /** @type {boolean} */ (event.data.isIdentity);
- var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.data.debuggerModel);
- if (isIdentity)
- return;
- var breakpoints = this._breakpointsForPrimaryUISourceCode.get(uiSourceCode) || [];
- for (var i = 0; i < breakpoints.length; ++i)
- breakpoints[i]._updateInDebuggerForModel(debuggerModel);
- }
-
/**
* @param {!Workspace.UISourceCode} uiSourceCode
*/

Powered by Google App Engine
This is Rietveld 408576698