Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js

Issue 2931773002: DevTools: kill DebuggerWorkspaceBinding.{push,pop,set}SourceMapping (Closed)
Patch Set: address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
index 704c107fa74b77ffa50d9873e6c576002493879b..5b2a98d6fbd5db05bd219c24a00e554598f374b7 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
@@ -183,19 +183,6 @@ InspectorTest.DebuggerModelMock = class extends SDK.SDKModel {
this._debuggerWorkspaceBinding._reset(this);
}
- pushSourceMapping(sourceMapping)
- {
- for (var scriptId in this._scripts)
- this._debuggerWorkspaceBinding.pushSourceMapping(this._scripts[scriptId], sourceMapping);
- }
-
- disableSourceMapping(sourceMapping)
- {
- sourceMapping._disabled = true;
- for (var scriptId in this._scripts)
- this._debuggerWorkspaceBinding.updateLocations(this._scripts[scriptId]);
- }
-
addBreakpointListener(breakpointId, listener, thisObject)
{
this._breakpointResolvedEventTarget.addEventListener(breakpointId, listener, thisObject)
@@ -232,7 +219,6 @@ InspectorTest.addScript = function(target, breakpointManager, url)
for (var i = 0; i < uiSourceCodes.length; ++i) {
var uiSourceCode = uiSourceCodes[i];
if (uiSourceCode.url() === url) {
- breakpointManager._debuggerWorkspaceBinding.setSourceMapping(target.debuggerModel, uiSourceCode, breakpointManager.defaultMapping);
InspectorTest.uiSourceCodes[url] = uiSourceCode;
return uiSourceCode;
}
@@ -253,11 +239,8 @@ InspectorTest.addUISourceCode = function(target, breakpointManager, url, doNotSe
InspectorTest.testNetworkProject._addResource(resource);
uiSourceCode = InspectorTest.testWorkspace.uiSourceCodeForURL(url);
- //var contentProvider = Common.StaticContentProvider.fromString(url, Common.resourceTypes.Script, "");
- //var uiSourceCode = InspectorTest.testNetworkProject.addFile(contentProvider, null);
InspectorTest.uiSourceCodes[url] = uiSourceCode;
if (!doNotSetSourceMapping) {
- breakpointManager._debuggerWorkspaceBinding.setSourceMapping(target.debuggerModel, uiSourceCode, breakpointManager.defaultMapping);
breakpointManager._debuggerWorkspaceBinding.updateLocations(target.debuggerModel.scriptForId(url));
}
return uiSourceCode;

Powered by Google App Engine
This is Rietveld 408576698