DevTools: kill DebuggerWorkspaceBinding.{push,pop,set}SourceMapping

third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Index: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
index 233e9e3d6446f90dce91446b575db99e946a7ec4..977685711778379b32d1a804f7e2d3a00cb5fc43 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
@@ -56,8 +56,6 @@ Bindings.BreakpointManager = class extends Common.Object {
     this._workspace.addEventListener(Workspace.Workspace.Events.ProjectRemoved, this._projectRemoved, this);
     this._workspace.addEventListener(Workspace.Workspace.Events.UISourceCodeAdded, this._uiSourceCodeAdded, this);
     this._workspace.addEventListener(Workspace.Workspace.Events.UISourceCodeRemoved, this._uiSourceCodeRemoved, this);
-    this._debuggerWorkspaceBinding.addEventListener(
-        Bindings.DebuggerWorkspaceBinding.Events.SourceMappingChanged, this._uiSourceCodeMappingChanged, this);
 
     targetManager.observeModels(SDK.DebuggerModel, this);
   }
@@ -172,20 +170,6 @@ Bindings.BreakpointManager = class extends Common.Object {
     this._removeUISourceCode(uiSourceCode);
   }
 
-  /**
-   * @param {!Common.Event} event
-   */
-  _uiSourceCodeMappingChanged(event) {
-    var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (event.data.uiSourceCode);
-    var isIdentity = /** @type {boolean} */ (event.data.isIdentity);
-    var debuggerModel = /** @type {!SDK.DebuggerModel} */ (event.data.debuggerModel);
-    if (isIdentity)

[dgozman, 2017/06/08 19:12:00]

Why don't we care anymore?

[lushnikov, 2017/06/08 21:14:34]

Every Bindings.BreakpointManager.Breakpoint has a set of ModelBreakpoints (one
per target), which in turn
have a liveLocation which is updated as the mapping gets changed.

This was added here:
https://chromium.googlesource.com/chromium/src/+/bb30709e356da03e07cb4a090ab1...

I verified that the scenario described in the patchset works fine with this
change.

-      return;
-    var breakpoints = this._breakpointsForPrimaryUISourceCode.get(uiSourceCode) || [];
-    for (var i = 0; i < breakpoints.length; ++i)
-      breakpoints[i]._updateInDebuggerForModel(debuggerModel);
-  }
-
   /**
    * @param {!Workspace.UISourceCode} uiSourceCode
    */