DevTools: kill DebuggerWorkspaceBinding.{push,pop,set}SourceMapping

third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 69 matching lines @@
 
   /**
    * @override
    * @param {!Workspace.UISourceCode} uiSourceCode
    * @param {number} lineNumber
    * @param {number} columnNumber
    * @return {?SDK.DebuggerModel.Location}
    */
   uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber) {
     var scripts = this._scriptsForUISourceCode(uiSourceCode);
+    if (!scripts.length)
+      return null;
     console.assert(scripts.length);

[dgozman, 2017/06/08 19:12:00]

Remove assert.

[lushnikov, 2017/06/08 21:14:34]

Done.

     var script = scripts[scripts.length - 1];
     if (script.isInlineScriptWithSourceURL()) {
       return this._debuggerModel.createRawLocationByURL(
           script.sourceURL, lineNumber + script.lineOffset,
           lineNumber ? columnNumber : columnNumber + script.columnOffset);
     }
     return this._debuggerModel.createRawLocationByURL(script.sourceURL, lineNumber, columnNumber);
   }
 
   /**
    * @param {!SDK.Script} script
    */
   addScript(script) {
     if (script.isAnonymousScript())
       return;
-    this._debuggerWorkspaceBinding.pushSourceMapping(script, this);
 
     var uiSourceCode = this._workspaceUISourceCodeForScript(script);
     if (!uiSourceCode)
       return;
 
     this._bindUISourceCodeToScripts(uiSourceCode, [script]);
   }
 
   /**
-   * @override
-   * @return {boolean}
-   */
-  isIdentity() {
-    return true;
-  }
-
-  /**
-   * @override
-   * @param {!Workspace.UISourceCode} uiSourceCode
-   * @param {number} lineNumber
-   * @return {boolean}
-   */
-  uiLineHasMapping(uiSourceCode, lineNumber) {
-    return true;
-  }
-
-  /**
    * @param {!Workspace.UISourceCode} uiSourceCode
    * @return {?Bindings.ResourceScriptFile}
    */
   scriptFile(uiSourceCode) {
     return this._uiSourceCodeToScriptFile.get(uiSourceCode) || null;
   }
 
   /**
    * @param {!Workspace.UISourceCode} uiSourceCode
    * @param {?Bindings.ResourceScriptFile} scriptFile
@@ skipping 71 matching lines @@
     // Due to different listeners order, a script file could be created just before uiSourceCode
     // for the corresponding script was created. Check that we don't create scriptFile twice.
     var boundScriptFile = this.scriptFile(uiSourceCode);
     if (boundScriptFile && boundScriptFile._hasScripts(scripts))
       return;
 
     var scriptFile = new Bindings.ResourceScriptFile(this, uiSourceCode, scripts);
     this._setScriptFile(uiSourceCode, scriptFile);
     for (var i = 0; i < scripts.length; ++i)
       this._debuggerWorkspaceBinding.updateLocations(scripts[i]);
-    this._debuggerWorkspaceBinding.setSourceMapping(this._debuggerModel, uiSourceCode, this);
     this._boundUISourceCodes.add(uiSourceCode);
   }
 
   /**
    * @param {!Workspace.UISourceCode} uiSourceCode
    */
   _unbindUISourceCode(uiSourceCode) {
     var scriptFile = this.scriptFile(uiSourceCode);
     if (scriptFile) {
       scriptFile.dispose();
       this._setScriptFile(uiSourceCode, null);
     }
-    this._debuggerWorkspaceBinding.setSourceMapping(this._debuggerModel, uiSourceCode, null);
     this._boundUISourceCodes.delete(uiSourceCode);

[dgozman, 2017/06/08 19:12:00]

updateLocations here

[lushnikov, 2017/06/08 21:14:34]

Done.

   }
 
   _debuggerReset() {
     for (var uiSourceCode of this._boundUISourceCodes.valuesArray())
       this._unbindUISourceCode(uiSourceCode);
     this._boundUISourceCodes.clear();
     console.assert(!this._uiSourceCodeToScriptFile.size);
   }
 
   dispose() {
@@ skipping 185 matching lines @@
   hasSourceMapURL() {
     return this._script && !!this._script.sourceMapURL;
   }
 };
 
 /** @enum {symbol} */
 Bindings.ResourceScriptFile.Events = {
   DidMergeToVM: Symbol('DidMergeToVM'),
   DidDivergeFromVM: Symbol('DidDivergeFromVM'),
 };