Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: cc/input/scrollbar_animation_controller.cc

Issue 2931703002: Don't fade in overlay scrollbar when user interacting the content under scrollbar. (Closed)
Patch Set: bokan comments addressed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/input/scrollbar_animation_controller.h ('k') | cc/input/scrollbar_animation_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/input/scrollbar_animation_controller.cc
diff --git a/cc/input/scrollbar_animation_controller.cc b/cc/input/scrollbar_animation_controller.cc
index 6d504cecdc40903608d9b35336909c739504fdc4..6234d3ce53f9b89bb89f8ed07c11ed6681961c12 100644
--- a/cc/input/scrollbar_animation_controller.cc
+++ b/cc/input/scrollbar_animation_controller.cc
@@ -53,6 +53,7 @@ ScrollbarAnimationController::ScrollbarAnimationController(
opacity_(initial_opacity),
show_scrollbars_on_scroll_gesture_(false),
need_thinning_animation_(false),
+ is_mouse_down_(false),
weak_factory_(this) {}
ScrollbarAnimationController::ScrollbarAnimationController(
@@ -74,6 +75,7 @@ ScrollbarAnimationController::ScrollbarAnimationController(
opacity_(initial_opacity),
show_scrollbars_on_scroll_gesture_(true),
need_thinning_animation_(true),
+ is_mouse_down_(false),
weak_factory_(this) {
vertical_controller_ = SingleScrollbarAnimationControllerThinning::Create(
scroll_element_id, ScrollbarOrientation::VERTICAL, client,
@@ -102,6 +104,7 @@ ScrollbarAnimationController::GetScrollbarAnimationController(
void ScrollbarAnimationController::StartAnimation() {
DCHECK(animation_change_ != NONE);
delayed_scrollbar_animation_.Cancel();
+ need_trigger_scrollbar_fade_in_ = false;
is_animating_ = true;
last_awaken_time_ = base::TimeTicks();
client_->SetNeedsAnimateForScrollbarAnimation();
@@ -109,6 +112,7 @@ void ScrollbarAnimationController::StartAnimation() {
void ScrollbarAnimationController::StopAnimation() {
delayed_scrollbar_animation_.Cancel();
+ need_trigger_scrollbar_fade_in_ = false;
is_animating_ = false;
animation_change_ = NONE;
}
@@ -224,21 +228,41 @@ void ScrollbarAnimationController::DidRequestShowFromMainThread() {
}
void ScrollbarAnimationController::DidMouseDown() {
- if (!need_thinning_animation_ || ScrollbarsHidden())
+ if (!need_thinning_animation_)
return;
+ is_mouse_down_ = true;
+
+ if (ScrollbarsHidden()) {
+ if (need_trigger_scrollbar_fade_in_) {
+ delayed_scrollbar_animation_.Cancel();
+ need_trigger_scrollbar_fade_in_ = false;
+ }
+ return;
+ }
+
vertical_controller_->DidMouseDown();
horizontal_controller_->DidMouseDown();
}
void ScrollbarAnimationController::DidMouseUp() {
- if (!need_thinning_animation_ || !Captured())
+ if (!need_thinning_animation_)
+ return;
+
+ is_mouse_down_ = false;
+
+ if (!Captured()) {
+ if (MouseIsNearAnyScrollbar() && ScrollbarsHidden()) {
+ PostDelayedAnimation(FADE_IN);
+ need_trigger_scrollbar_fade_in_ = true;
+ }
return;
+ }
vertical_controller_->DidMouseUp();
horizontal_controller_->DidMouseUp();
- if (!MouseIsNearAnyScrollbar())
+ if (!MouseIsNearAnyScrollbar() && !ScrollbarsHidden())
PostDelayedAnimation(FADE_OUT);
}
@@ -268,12 +292,17 @@ void ScrollbarAnimationController::DidMouseMove(
vertical_controller_->DidMouseMove(device_viewport_point);
horizontal_controller_->DidMouseMove(device_viewport_point);
- need_trigger_scrollbar_fade_in_ = MouseIsNearAnyScrollbar();
-
- if (Captured())
+ if (Captured()) {
+ DCHECK(!ScrollbarsHidden());
return;
+ }
if (ScrollbarsHidden()) {
+ // Do not fade in scrollbar when user interacting with the content below
+ // scrollbar.
+ if (is_mouse_down_)
+ return;
+ need_trigger_scrollbar_fade_in_ = MouseIsNearAnyScrollbar();
if (need_trigger_scrollbar_fade_in_before !=
need_trigger_scrollbar_fade_in_) {
if (need_trigger_scrollbar_fade_in_) {
« no previous file with comments | « cc/input/scrollbar_animation_controller.h ('k') | cc/input/scrollbar_animation_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698