Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

Issue 2931673004: Make InlineBoxPosition constructor not to accept null-InlineBox (Closed)
Patch Set: 2017-06-12T14:51:57 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
index f463135aafb1ccc858fa1f42bf9e1796366e69de..6b2f9149f8df5f2a57b0a5ebff194ce4bdec4445 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
@@ -303,9 +303,7 @@ TEST_F(VisibleUnitsTest, ComputeInlineBoxPositionMixedEditable) {
Position::LastPositionInNode(sample), TextAffinity::kDownstream);
// Should not be in infinite-loop
EXPECT_EQ(nullptr, actual.inline_box);
- // TODO(editing-dev): We should return 0 for |InlineBoxPosition| when
- // |inline_box| is null.
- EXPECT_EQ(2, actual.offset_in_box);
+ EXPECT_EQ(0, actual.offset_in_box);
}
TEST_F(VisibleUnitsTest, endOfDocument) {

Powered by Google App Engine
This is Rietveld 408576698