Updated HttpServer documentation to specify that only IPv6 connections can be made when specifying …

Updated HttpServer documentation to specify that only IPv6 connections can be made when specifying InternetAddress.LOOPBACK_IP_V6 as the address for a HttpServer. Refer to buganizer issue 38306174 for context.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/4a15b0b6026be44339e3387a51032140fc7934de

[bkonyi, 2017-06-07 23:11:04]

bkonyi@google.com changed reviewers:
+ asiva@google.com, zra@google.com

[bkonyi, 2017-06-07 23:11:04]

Context: https://buganizer.corp.google.com/issues/38306174

[zra, 2017-06-08 17:16:25]

If we don't already have a unit test of this behavior, could you add one? If
there is already a test of this behavior, could you note it in the CL
description? Thanks!

[bkonyi, 2017-06-08 19:51:58]

Added a unit test that shows the expected behavior when using the loopback
addresses. PTAL.

[zra, 2017-06-08 20:05:24]

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
File tests/standalone/io/http_loopback_test.dart (right):

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:28: client.close();
await

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:37: server.close();
await

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:48: client.close();
await

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:57: server.close();
await

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:67: client.close();
await

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:72: server.close();
await

[bkonyi, 2017-06-08 21:36:10]

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
File tests/standalone/io/http_loopback_test.dart (right):

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:28: client.close();
On 2017/06/08 20:05:24, zra wrote:
> await

Done.

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:37: server.close();
On 2017/06/08 20:05:24, zra wrote:
> await

Done.

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:48: client.close();
On 2017/06/08 20:05:24, zra wrote:
> await

Done.

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:57: server.close();
On 2017/06/08 20:05:24, zra wrote:
> await

Done.

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:67: client.close();
On 2017/06/08 20:05:24, zra wrote:
> await

Done.

https://codereview.chromium.org/2931623003/diff/20001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:72: server.close();
On 2017/06/08 20:05:24, zra wrote:
> await

Done.

[zra, 2017-06-08 21:45:21]

https://codereview.chromium.org/2931623003/diff/40001/tests/standalone/io/htt...
File tests/standalone/io/http_loopback_test.dart (right):

https://codereview.chromium.org/2931623003/diff/40001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:12: void serverListen(RawSocket
serverSide) async {
The analyzer will complain about this because async functions always return a
Future.

https://codereview.chromium.org/2931623003/diff/40001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:13: void serveData(RawSocketEvent
event) async {
ditto

https://codereview.chromium.org/2931623003/diff/40001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:15: await server.close();
server is already closed below in the finally blocks, so it isn't needed here is
it?

[bkonyi, 2017-06-08 22:49:38]

https://codereview.chromium.org/2931623003/diff/40001/tests/standalone/io/htt...
File tests/standalone/io/http_loopback_test.dart (right):

https://codereview.chromium.org/2931623003/diff/40001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:12: void serverListen(RawSocket
serverSide) async {
On 2017/06/08 21:45:21, zra wrote:
> The analyzer will complain about this because async functions always return a
> Future.

I've gone ahead and removed the void token from the async methods.

https://codereview.chromium.org/2931623003/diff/40001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:13: void serveData(RawSocketEvent
event) async {
On 2017/06/08 21:45:21, zra wrote:
> ditto

Done.

https://codereview.chromium.org/2931623003/diff/40001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:15: await server.close();
On 2017/06/08 21:45:21, zra wrote:
> server is already closed below in the finally blocks, so it isn't needed here
is
> it?

You're right, I just forgot to remove this. Done.

[zra, 2017-06-08 22:50:49]

lgtm after removing unneeded asyncs

https://codereview.chromium.org/2931623003/diff/60001/tests/standalone/io/htt...
File tests/standalone/io/http_loopback_test.dart (right):

https://codereview.chromium.org/2931623003/diff/60001/tests/standalone/io/htt...
tests/standalone/io/http_loopback_test.dart:11: serverListen(RawSocket
serverSide) async {
Now there's no reason for these to be async.

[bkonyi, 2017-06-08 22:53:13]

Description was changed from

==========
Updated HttpServer documentation to specify that only IPv6 connections can be
made when specifying InternetAddress.LOOPBACK_IP_V6 as the address for a
HttpServer. Refer to buganizer issue 38306174 for context.

BUG=
==========

to

==========
Updated HttpServer documentation to specify that only IPv6 connections can be
made when specifying InternetAddress.LOOPBACK_IP_V6 as the address for a
HttpServer. Refer to buganizer issue 38306174 for context.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4a15b0b6026be44339e3387a51032140fc7934de
==========

[bkonyi, 2017-06-08 22:53:14]

Committed patchset #5 (id:80001) manually as
4a15b0b6026be44339e3387a51032140fc7934de (presubmit successful).