Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2931603003: Set main procedure for Program. (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set main procedure for Program. Why is it called main _method_ when it is actually Procedure? R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/400c7a0cb5e97db1386b6e2171387075f1797ab6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 5 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 6 months ago (2017-06-07 17:25:10 UTC) #1
ahe
lgtm In Kernel terminology, a procedure is either a method, a getter, a setter, an ...
3 years, 6 months ago (2017-06-07 17:34:53 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 400c7a0cb5e97db1386b6e2171387075f1797ab6 (presubmit successful).
3 years, 6 months ago (2017-06-07 17:59:38 UTC) #4
Siggi Cherem (dart-lang)
3 years, 6 months ago (2017-06-07 18:14:27 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698