Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: chrome/browser/win/jumplist_factory.h

Issue 2931573003: Fix stability and data racing issues, coalesce more updates for JumpList (Closed)
Patch Set: Remove null check Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/win/jumplist.cc ('k') | chrome/browser/win/jumplist_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/win/jumplist_factory.h
diff --git a/chrome/browser/win/jumplist_factory.h b/chrome/browser/win/jumplist_factory.h
index 5f8c1c80180dc5fdf67eebf8ddd68570879ac593..7155c807868b9bc3bf4ec0b6ac14dbb6ff89f7e0 100644
--- a/chrome/browser/win/jumplist_factory.h
+++ b/chrome/browser/win/jumplist_factory.h
@@ -6,12 +6,14 @@
#define CHROME_BROWSER_WIN_JUMPLIST_FACTORY_H_
#include "base/memory/singleton.h"
-#include "chrome/browser/win/jumplist.h"
-#include "components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h"
+#include "components/keyed_service/content/browser_context_keyed_service_factory.h"
-class JumpListFactory : public RefcountedBrowserContextKeyedServiceFactory {
+class Profile;
+class JumpList;
+
+class JumpListFactory : public BrowserContextKeyedServiceFactory {
public:
- static scoped_refptr<JumpList> GetForProfile(Profile* profile);
+ static JumpList* GetForProfile(Profile* profile);
static JumpListFactory* GetInstance();
@@ -21,7 +23,7 @@ class JumpListFactory : public RefcountedBrowserContextKeyedServiceFactory {
~JumpListFactory() override;
// BrowserContextKeyedServiceFactory:
- scoped_refptr<RefcountedKeyedService> BuildServiceInstanceFor(
+ KeyedService* BuildServiceInstanceFor(
content::BrowserContext* context) const override;
};
« no previous file with comments | « chrome/browser/win/jumplist.cc ('k') | chrome/browser/win/jumplist_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698