Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3237)

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 2931573003: Fix stability and data racing issues, coalesce more updates for JumpList (Closed)
Patch Set: Fix nits and update comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.h
diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h
index 0b714ec406baa1d2fb13518c16c3224fc18154b8..a9c32104a2531099c7d667b72499419bfb490958 100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -688,8 +688,8 @@ class BrowserView : public BrowserWindow,
// Helper class to listen for completion of first page load.
std::unique_ptr<LoadCompleteListener> load_complete_listener_;
- // The custom JumpList for Windows 7.
- scoped_refptr<JumpList> jumplist_;
+ // The custom JumpList for Windows.
+ JumpList* jumplist_ = nullptr;
Peter Kasting 2017/06/12 22:21:54 I'm a fan of this kind of in-declaration initializ
grt (UTC plus 2) 2017/06/13 07:32:27 I agree with Peter here. Apologies for suggesting
chengx 2017/06/13 19:16:01 Done.
chengx 2017/06/13 19:16:01 I've landed crrev/2939583002 to apply the in-decla
#endif
// The timer used to update frames for the Loading Animation.
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | chrome/browser/ui/views/frame/browser_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698