Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2175)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2931573003: Fix stability and data racing issues, coalesce more updates for JumpList (Closed)
Patch Set: Fix nits and update comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index e9fe68b85300acb519b0cdb11b14d49ebdf14321..4c9ce5738431529979cd1a25a80ddbf162d15027 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -2178,7 +2178,7 @@ void BrowserView::LoadingAnimationCallback() {
void BrowserView::OnLoadCompleted() {
#if defined(OS_WIN)
- DCHECK(!jumplist_.get());
+ DCHECK(!jumplist_);
jumplist_ = JumpListFactory::GetForProfile(browser_->profile());
grt (UTC plus 2) 2017/06/13 07:32:27 on the other hand, is this jumplist_ member even n
chengx 2017/06/13 19:16:01 I don't think |jumplist_| is needed, so removed it
#endif
}

Powered by Google App Engine
This is Rietveld 408576698