Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: chrome/browser/win/jumplist_factory.cc

Issue 2931573003: Fix stability and data racing issues, coalesce more updates for JumpList (Closed)
Patch Set: Remove refcounting for jumplist KeyedService, fix nits. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/win/jumplist_factory.cc
diff --git a/chrome/browser/win/jumplist_factory.cc b/chrome/browser/win/jumplist_factory.cc
index 92b10bbe0c95e48e73c8b4f435409870896cb5d4..32623f72532fdb1bf0fb1f5ea0879d69dbb7abd4 100644
--- a/chrome/browser/win/jumplist_factory.cc
+++ b/chrome/browser/win/jumplist_factory.cc
@@ -11,9 +11,9 @@
#include "components/keyed_service/content/browser_context_dependency_manager.h"
// static
-scoped_refptr<JumpList> JumpListFactory::GetForProfile(Profile* profile) {
+JumpList* JumpListFactory::GetForProfile(Profile* profile) {
return static_cast<JumpList*>(
- GetInstance()->GetServiceForBrowserContext(profile, true).get());
+ GetInstance()->GetServiceForBrowserContext(profile, true));
}
// static
@@ -22,7 +22,7 @@ JumpListFactory* JumpListFactory::GetInstance() {
}
JumpListFactory::JumpListFactory()
- : RefcountedBrowserContextKeyedServiceFactory(
+ : BrowserContextKeyedServiceFactory(
"JumpList",
BrowserContextDependencyManager::GetInstance()) {
DependsOn(TabRestoreServiceFactory::GetInstance());
@@ -32,7 +32,7 @@ JumpListFactory::JumpListFactory()
JumpListFactory::~JumpListFactory() = default;
-scoped_refptr<RefcountedKeyedService> JumpListFactory::BuildServiceInstanceFor(
+KeyedService* JumpListFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
return new JumpList(Profile::FromBrowserContext(context));
}
« chrome/browser/win/jumplist_factory.h ('K') | « chrome/browser/win/jumplist_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698