Fix stability and data racing issues, coalesce more updates for JumpList

chrome/browser/win/jumplist_factory.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WIN_JUMPLIST_FACTORY_H_
 #define CHROME_BROWSER_WIN_JUMPLIST_FACTORY_H_
 
 #include "base/memory/singleton.h"
 #include "chrome/browser/win/jumplist.h"

[grt (UTC plus 2), 2017/06/12 20:43:39]

nit: could this be moved to the .cc file in favor of a forward-decl?

[chengx, 2017/06/12 22:05:30]

I don't think so. The return type of GetForProfile is JumpList*. So the
definition of JumpList is needed in this header file. 

[grt (UTC plus 2), 2017/06/13 07:32:27]

A forward decl is fine in that case -- consumers of this .h only need to know
that "JumpList" is a class. They will need to include jumplist.h only if they
wish to dereference the pointer.

[chengx, 2017/06/13 19:16:01]

Done. You are right. I only need to tell the header file that JumpList is a
class. Thanks!

-#include "components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h"
+#include "components/keyed_service/content/browser_context_keyed_service_factory.h"
 
-class JumpListFactory : public RefcountedBrowserContextKeyedServiceFactory {
+class JumpListFactory : public BrowserContextKeyedServiceFactory {
  public:
-  static scoped_refptr<JumpList> GetForProfile(Profile* profile);
+  static JumpList* GetForProfile(Profile* profile);
 
   static JumpListFactory* GetInstance();
 
  private:
   friend struct base::DefaultSingletonTraits<JumpListFactory>;
   JumpListFactory();
   ~JumpListFactory() override;
 
   // BrowserContextKeyedServiceFactory:
-  scoped_refptr<RefcountedKeyedService> BuildServiceInstanceFor(
+  KeyedService* BuildServiceInstanceFor(
       content::BrowserContext* context) const override;
 };
 
 #endif  // CHROME_BROWSER_WIN_JUMPLIST_FACTORY_H_