Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 293153002: chrome.bluetoothLowEnergy: Implement writeDescriptorValue. (Closed)

Created:
6 years, 7 months ago by armansito
Modified:
6 years, 7 months ago
Reviewers:
keybuk
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

chrome.bluetoothLowEnergy: Implement writeDescriptorValue. This CL implements the writeDescriptorValue function of the bluetoothLowEnergy API. BUG=265663 TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272600

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Messages

Total messages: 16 (0 generated)
armansito
6 years, 7 months ago (2014-05-22 19:35:57 UTC) #1
keybuk
lgtm https://codereview.chromium.org/293153002/diff/1/chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/runtest.js File chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/runtest.js (right): https://codereview.chromium.org/293153002/diff/1/chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/runtest.js#newcode26 chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/runtest.js:26: nit: really?
6 years, 7 months ago (2014-05-22 21:08:52 UTC) #2
armansito
https://codereview.chromium.org/293153002/diff/1/chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/runtest.js File chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/runtest.js (right): https://codereview.chromium.org/293153002/diff/1/chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/runtest.js#newcode26 chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/runtest.js:26: On 2014/05/22 21:08:53, keybuk wrote: > nit: really? Haha, ...
6 years, 7 months ago (2014-05-23 00:55:03 UTC) #3
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 7 months ago (2014-05-23 08:11:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/293153002/10001
6 years, 7 months ago (2014-05-23 08:12:46 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 12:40:00 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 13:52:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/30467)
6 years, 7 months ago (2014-05-23 13:52:01 UTC) #8
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 7 months ago (2014-05-23 15:07:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/293153002/10001
6 years, 7 months ago (2014-05-23 15:08:02 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 16:15:36 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 17:50:48 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/32100)
6 years, 7 months ago (2014-05-23 17:50:48 UTC) #13
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 7 months ago (2014-05-23 19:30:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/293153002/10001
6 years, 7 months ago (2014-05-23 19:31:08 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 21:49:50 UTC) #16
Message was sent while issue was closed.
Change committed as 272600

Powered by Google App Engine
This is Rietveld 408576698