Issue 2931463002: Revert "Entity-ify some portions of LocalsHandler and Closure."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2931463002: Revert "Entity-ify some portions of LocalsHandler and Closure." (Closed)

Created:
3 years, 6 months ago by Emily Fortuna

Modified:
3 years, 6 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Entity-ify some portions of LocalsHandler and Closure." This reverts commit 03572798ff52f4e626d2fc5f40e13c3daf9999fd. It was causing some type warnings. BUG= Committed: https://github.com/dart-lang/sdk/commit/cdb41f9258376ab48f694021dc8869f1c8c5b7b8

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -14 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View	6 chunks	+17 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/locals_handler.dart	View	5 chunks	+8 lines, -6 lines	0 comments	Download
M	tests/compiler/dart2js/serialization/model_test_helper.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Emily Fortuna

Committed patchset #1 (id:1) manually as cdb41f9258376ab48f694021dc8869f1c8c5b7b8 (presubmit successful).

3 years, 6 months ago (2017-06-06 19:10:22 UTC) #4

Message was sent while issue was closed.

lgtm