Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: ios/web/public/test/http_server/http_server.h

Issue 2931453002: Re-enable reading list tests (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/test/http_server/http_server.h
diff --git a/ios/web/public/test/http_server/http_server.h b/ios/web/public/test/http_server/http_server.h
index c565eb60613cbc865bdc641f4aef1fe179fd68d1..17d6da4a525cb97005a0384a3c72060fbe37c6ed 100644
--- a/ios/web/public/test/http_server/http_server.h
+++ b/ios/web/public/test/http_server/http_server.h
@@ -80,6 +80,8 @@ class HttpServer : public base::RefCountedThreadSafe<HttpServer> {
// Returns true if the server is running.
// Must be called from the main thread.
bool IsRunning() const;
+ // Sets the server to hang and return no response.
+ void setSuspend(BOOL suspended);
baxley 2017/06/06 18:14:17 would it be more consistent if this is "bool"? wha
huangml1 2017/06/07 18:10:54 I feel that setSuspend is more like an action than
baxley 2017/06/07 18:21:06 I meant more that the rest of this is C++. If the
// Returns the port that the server is running on. Thread Safe
NSUInteger GetPort() const;
@@ -136,6 +138,8 @@ class HttpServer : public base::RefCountedThreadSafe<HttpServer> {
// ResponseProvider response back to EmbeddedTestServer response.
std::unique_ptr<net::test_server::HttpResponse> GetResponse(
const net::test_server::HttpRequest& request);
+ // The status that if the server hangs.
baxley 2017/06/06 18:14:17 "Status tracking if the server is hung."
huangml1 2017/06/07 18:10:54 Done.
+ BOOL isSuspended;
baxley 2017/06/06 18:14:17 bool?
huangml1 2017/06/07 18:10:54 Done.
DISALLOW_COPY_AND_ASSIGN(HttpServer);
};

Powered by Google App Engine
This is Rietveld 408576698