Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: content/public/android/java/res/values-v17/styles.xml

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)
Patch Set: Reduce code duplication in TextSuggestionController Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/res/values-v17/styles.xml
diff --git a/content/public/android/java/res/values-v17/styles.xml b/content/public/android/java/res/values-v17/styles.xml
index 58d8ed49117c7ce361ab1ee6d4e42373ef058201..a9d163b231b2b4f1ecd996e5810af118ccb1f2f6 100644
--- a/content/public/android/java/res/values-v17/styles.xml
+++ b/content/public/android/java/res/values-v17/styles.xml
@@ -16,4 +16,28 @@
<style name="SelectActionMenuWebSearch">
<item name="android:icon">@drawable/ic_search</item>
</style>
+ <style name="TextSuggestionButton">
+ <item name="android:drawablePadding">8dip</item>
+ <!-- v21 uses sans-serif-medium -->
Theresa 2017/07/18 15:37:51 If v21 uses sans-serif-medium then you should prob
rlanday 2017/07/19 00:23:55 I'd love to get this to match, but your suggestion
Theresa 2017/07/19 15:10:50 It would only change the appearance on Pre-L devic
rlanday 2017/07/19 22:03:43 Ok, done. Updated screenshots here: https://docs.g
+ <item name="android:fontFamily">sans-serif</item>
+ <item name="android:gravity">start|center_vertical</item>
+ <item name="android:layout_gravity">start|center_vertical</item>
+ <item name="android:layout_height">48dip</item>
Theresa 2017/07/18 15:37:51 nit: Same comment about dip here
+ <item name="android:layout_width">match_parent</item>
+ <item name="android:paddingBottom">8dip</item>
+ <item name="android:paddingEnd">16dip</item>
+ <item name="android:paddingStart">16dip</item>
+ <item name="android:paddingTop">8dip</item>
+ <item name="android:singleLine">true</item>
+ <!-- v21 uses android:attr/colorAccent -->
+ <item name="android:textColor">@color/google_blue_500</item>
+ <item name="android:textAllCaps">true</item>
+ <item name="android:textSize">14sp</item>
+ </style>
+ <style name="TextSuggestionWindowContainer">
+ <item name="android:layout_width">match_parent</item>
+ <item name="android:layout_height">wrap_content</item>
+ <item name="android:layout_margin">@dimen/text_suggestion_window_container_margin</item>
+ <item name="android:orientation">vertical</item>
+ </style>
</resources>

Powered by Google App Engine
This is Rietveld 408576698