content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)

Patch Set: Remove some unused fields in SuggestionsPopupWindow, don't hold reference to mutable array passed in Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/res/values-v17/styles.xml ('k') | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | third_party/WebKit/Source/core/editing/suggestion/TextSuggestionController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index ddb753026220c0bd462255d39ab0eaf72d203043..16fcf712b8cb12c20e53635279c1abcd73b50c59 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -457,8 +457,8 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

setContainerViewInternals(internalDispatcher);

initPopupZoomer(mContext);

- mImeAdapter = new ImeAdapter(

- mWebContents, mContainerView, new InputMethodManagerWrapper(mContext));

+ mImeAdapter = new ImeAdapter(mWebContents, mContainerView,

+ new InputMethodManagerWrapper(mContext), mRenderCoordinates);

mImeAdapter.addEventObserver(this);

mSelectionPopupController = new SelectionPopupController(

@@ -983,6 +983,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

destroyPastePopup();

hideSelectPopupWithCancelMessage();

mPopupZoomer.hide(false);

+ mImeAdapter.hidePopups();

}

private void restoreSelectionPopupsIfNecessary() {

@@ -2172,6 +2173,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

hidePopupsAndPreserveSelection();

showSelectActionMode();

}

+ mImeAdapter.hidePopups();

int rotationDegrees = 0;

switch (rotation) {