Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)
Patch Set: Remove some unused fields in SuggestionsPopupWindow, don't hold reference to mutable array passed in Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 2da5ad962dfed375abda9c138e1ef5a92d183fbd..7a08196c8a4dd394247d5279a3f546c2a4ab8925 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -940,6 +940,11 @@ bool RenderWidgetHostViewAndroid::OnTouchEvent(
ComputeEventLatencyOSTouchHistograms(event);
+ // Receiving any other touch event before the double-tap timeout expires
+ // cancels opening the spellcheck menu.
+ if (ime_adapter_android_)
+ ime_adapter_android_->StopSpellCheckMenuTimer();
+
// If a browser-based widget consumes the touch event, it's critical that
// touch event interception be disabled. This avoids issues with
// double-handling for embedder-detected gestures like side swipe.

Powered by Google App Engine
This is Rietveld 408576698