content/public/android/java/res/layout-v21/text_edit_suggestion_container.xml - Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/android/java/res/layout-v21/text_edit_suggestion_container.xml

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)

Patch Set: Consolidate mContentView and mContainerView Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/public/android/java/res/drawable/floating_popup_background_light.xml ('k') | content/public/android/java/res/layout/text_edit_suggestion_container.xml » ('j') | content/public/android/java/src/org/chromium/content/browser/input/SuggestionsPopupWindow.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- Based on Android's text_edit_suggestion_container_material.xml -->

	7 <!-- On Lollipop and later (this file), we draw a drop shadow by programmaticall y setting elevation

	8 on the PopupWindow.

	9 On pre-Lollipop, we instead draw the drop shadow using

	10 @drawable/dropdown_popup_background. -->

	11

	12 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	13 style="@style/TextSuggestionWindowContainer"

	14 android:id="@+id/suggestionWindowContainer"

	15 android:background="@drawable/floating_popup_background_light">
	Theresa 2017/07/19 15:10:50 Since the only difference in the two files is now Since the only difference in the two files is now the background, and we have to check Lollipop or not to set the elevation programatically, let's set the background programatically as well and remove one of this XML file. Once they are combined, I would drop in-line the attributes in @style/TextSuggestionWindowContainer rather then defining them in styles.xml. rlanday 2017/07/19 22:03:43 Done Show quoted text On 2017/07/19 at 15:10:50, Theresa wrote: > Since the only difference in the two files is now the background, and we have to check Lollipop or not to set the elevation programatically, let's set the background programatically as well and remove one of this XML file. > > > Once they are combined, I would drop in-line the attributes in @style/TextSuggestionWindowContainer rather then defining them in styles.xml. Done
	16 <ListView

	17 android:id="@+id/suggestionContainer"

	18 android:layout_width="match_parent"

	19 android:layout_height="wrap_content" />

	20 </LinearLayout>

OLD	NEW