content/public/android/java/res/values-v17/styles.xml - Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews

Side by Side Diff: content/public/android/java/res/values-v17/styles.xml

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)

Patch Set: Remove leftover traces Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « content/public/android/java/res/layout/text_edit_suggestion_item.xml ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <resources>	8 <resources>

9 <style name="SelectPopupDialog">	9 <style name="SelectPopupDialog">

10 <item name="select_dialog_singlechoice">@android:layout/select_dialog_si nglechoice</item>	10 <item name="select_dialog_singlechoice">@android:layout/select_dialog_si nglechoice</item>

11 <item name="select_dialog_multichoice">@android:layout/select_dialog_mul tichoice</item>	11 <item name="select_dialog_multichoice">@android:layout/select_dialog_mul tichoice</item>

12 </style>	12 </style>

13 <style name="SelectActionMenuShare">	13 <style name="SelectActionMenuShare">

14 <item name="android:icon">@drawable/ic_menu_share_holo_light</item>	14 <item name="android:icon">@drawable/ic_menu_share_holo_light</item>

15 </style>	15 </style>

16 <style name="SelectActionMenuWebSearch">	16 <style name="SelectActionMenuWebSearch">

17 <item name="android:icon">@drawable/ic_search</item>	17 <item name="android:icon">@drawable/ic_search</item>

18 </style>	18 </style>

	19 <style name="TextSuggestionButton">

	20 <item name="android:drawablePadding">8dip</item>

	21 <item name="android:fontFamily">sans-serif-medium</item>
	rlanday 2017/06/28 01:35:34 I think sans-serif-medium was added in Lollipop so I think sans-serif-medium was added in Lollipop so the text looks thinner on Kit Kat. Not sure if there's anything we can do about this. I suppose I should use sans-serif in the v17 file just so we're not using an invalid option (it still looks thin)
	22 <item name="android:gravity">start\|center_vertical</item>

	23 <item name="android:layout_gravity">start\|center_vertical</item>

	24 <item name="android:layout_height">48dip</item>

	25 <item name="android:layout_width">match_parent</item>

	26 <item name="android:paddingBottom">8dip</item>

	27 <item name="android:paddingEnd">16dip</item>

	28 <item name="android:paddingStart">16dip</item>

	29 <item name="android:paddingTop">8dip</item>

	30 <item name="android:singleLine">true</item>

	31 <item name="android:textColor">?android:attr/colorAccent</item>
	rlanday 2017/06/28 01:35:34 It turns out that android:attr/colorAccent was add It turns out that android:attr/colorAccent was added in API level 21 so this crashes on Kit Kat. I could hard code a color here but right now e.g. we have different colors in Chrome (green, which I think is the default) and Gmail (blue), so it'd be nice to still support this. I guess I'll provide a separate version of this file for v21?
	32 <item name="android:textAllCaps">true</item>

	33 <item name="android:textSize">14sp</item>

	34 </style>

19 </resources>	35 </resources>

OLD	NEW