Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: content/browser/android/text_suggestion_host_impl.h

Issue 2931443003: Add support for Android spellcheck menu in Chrome/WebViews (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef TEXT_SUGGESTION_HOST_IMPL_H_
6 #define TEXT_SUGGESTION_HOST_IMPL_H_
7
8 #include "third_party/WebKit/public/platform/input_host.mojom.h"
9
10 namespace service_manager {
11 struct BindSourceInfo;
12 }
13
14 namespace content {
15
16 class ImeAdapterAndroid;
17
18 class TextSuggestionHostImpl : public blink::mojom::TextSuggestionHost {
yosin_UTC9 2017/06/07 01:34:15 Could you add class level comment? Is this |final|
19 public:
20 explicit TextSuggestionHostImpl(ImeAdapterAndroid*);
21
22 static void Create(ImeAdapterAndroid*,
23 const service_manager::BindSourceInfo& source_info,
24 blink::mojom::TextSuggestionHostRequest request);
25
26 void StartSpellCheckMenuTimer();
27
28 void ShowSpellCheckSuggestionMenu(
29 double caret_x,
30 double caret_y,
31 const std::string& marked_text,
32 std::vector<blink::mojom::SpellCheckSuggestionPtr> suggestions) override;
33
34 private:
35 ImeAdapterAndroid* ime_adapter_android_;
yosin_UTC9 2017/06/07 01:34:15 nit: s/ImeAdapterAndroid*/ImeAdapterAndroid* const
36 };
yosin_UTC9 2017/06/07 01:34:15 Please add DISALLOW_COPY_AND_ASSIGN(...)
37
38 } // namespace content
39
40 #endif // TEXT_SUGGESTION_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698